This repository has been archived by the owner on Jun 8, 2022. It is now read-only.
Pwabuilder issue 861 & 859 #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks lee-leonardo for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
ghost
assigned 
lee-leonardo
commented
Jul 24, 2020
| @@ -753,7 +775,8 @@ export class pwainstall extends LitElement { | |||
| </div> | |||
| </div> | |||
|
|
|||
| <button id="closeButton" @click="${() => this.cancel()}"> | |||
| <button id="closeButton" @click="${() => | |||
| this.cancel()}" aria-label="Close"> | |||
There was a problem hiding this comment.
added aria here
lee-leonardo
commented
Jul 24, 2020
| <div id="screenshotsContainer"> | ||
| <button | ||
| @click="${() => this.scrollToLeft()}" | ||
| aria-label="previous image" |
There was a problem hiding this comment.
added label here
lee-leonardo
commented
Jul 24, 2020
| </section> | ||
| <button | ||
| @click="${() => this.scrollToRight()}" | ||
| aria-label="next image" |
There was a problem hiding this comment.
added aria here
jgw96
approved these changes
Jul 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
pwa-builder/PWABuilder#861
pwa-builder/PWABuilder#859
PR Type
Describe the current behavior?
The close, and left and right image carousels do not have the appropriate aria-labels
Describe the new behavior?
Added them.
PR Checklist
npm run testand ensure that all tests passAdditional Information
Sorry about the white space changes! I'll mark what I actually changed!