Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Screen Reader - PWA Builder - PWA Builder Generate] : Screen Reader Not reading the heading level of "Key Features" heading in PWA builder dialogue box #861

Closed
Priyanka-Chauhan123 opened this issue Jun 23, 2020 · 4 comments
Assignees
Labels
bug 🐛 fixed bug is marked as resolved and ready to validate

Comments

@Priyanka-Chauhan123
Copy link

Priyanka-Chauhan123 commented Jun 23, 2020

User Experience:
If headings are not clear and descriptive, it would be difficult for screen reader dependent users to find the information they seek , and cannot understand the relationships between different parts of the content. Also if labels are not Descriptive users can not identify specific components within the content.

Test Environment:
OS: Windows 10 build 19608.1006
Browser: Edge - Anaheim - Version 85.0.545.0 (Official build) dev (64-bit)
URL: https://preview.pwabuilder.com/generate

Repro Steps:

  1. Open URL: https://preview.pwabuilder.com/generate in Edge Anaheim dev browser.
  2. Navigate to Download PWA Builder button and press enter
  3. Now with scan mode on move focus to the  key features heading and observe what screen reader reads.
  4. Observe the issue.

Actual Result:
The screen reader reads the heading as "Key Features" only

Expected Result:
The screen reader should read the heading as "Heading level 3, Key features".

MAS Reference:
https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={0cf80872-800d-4643-90cf-0c1c3d3e6260}

Note:
Same bug was found on the "Description" heading on the same modal box.

PWABuilder - Personal - Microsoft​ Edge 6_23_2020 4_24_23 PM
2.4.6 Heading and Labels Headings.zip

@ghost
Copy link

ghost commented Jun 23, 2020

Hello Priyanka-Chauhan123, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will investigate the issue and help solve it ASAP. Other community members may also look into the issue and provide feedback 🙌

@Priyanka-Chauhan123 Priyanka-Chauhan123 changed the title [Screen Reader - PWA Builder - PWA Builder Generate] : Screen Reader Not reading the heading level of "Key Features" heading in pwa \\builder dialogue box [Screen Reader - PWA Builder - PWA Builder Generate] : Screen Reader Not reading the heading level of "Key Features" heading in PWA builder dialogue box Jun 23, 2020
@ghost ghost added the needs attention 👋 label Jul 14, 2020
@ghost
Copy link

ghost commented Jul 14, 2020

This issue has been marked as "needs attention 👋" due to no activity for 15 days. Please triage the issue so the fix can be established.

@lee-leonardo
Copy link
Contributor

lee-leonardo commented Jul 24, 2020

no repro, but the buttons in the install component for close and the carousel are missing descriptive labels.

@lee-leonardo lee-leonardo self-assigned this Jul 24, 2020
@lee-leonardo lee-leonardo added the fixed bug is marked as resolved and ready to validate label Aug 3, 2020
@Ajesh-k
Copy link

Ajesh-k commented Aug 26, 2020

Issue has been fixed on below Test Environment as:
OS: Version 2004 (OS Build20190.1000)
Browser:Version 86.0.608.2 (Official build) dev (64-bit)
Hence, closing the bug

@Ajesh-k Ajesh-k closed this as completed Aug 26, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug 🐛 fixed bug is marked as resolved and ready to validate
Projects
None yet
Development

No branches or pull requests

6 participants