CAT-1670 - Fix onTypeFormatting due to undefined variable json_rpc_handler #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, we would see in the language server logs that we were referencing an undefined variable `json_rpc_handler`. This had knock on effects, such as registering the onTypeformatting provider, meaning this setting would not work when enabled. We now update the json_rpc_handler send message event to be consistent with the rest of the language server, and to fix the undefined variable error. The dynamically registered providers, like onTypeFormatting, will now work as expected.
jordanbreen28
force-pushed
the
CAT-1670-fix_allignment
branch
from
d6d0825
to
0a26044
Compare
jordanbreen28
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #376 +/- ##
==========================================
- Coverage 11.69% 11.69% -0.01%
==========================================
Files 92 92
Lines 11501 11504 +3
==========================================
Hits 1345 1345
- Misses 10156 10159 +3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Prior to this PR, we would see in the language server logs that we were referencing an undefined variable
json_rpc_handler.This had knock on effects, such as registering the onTypeformatting provider, meaning this setting would not work when enabled.
We now update the json_rpc_handler send message event to be consistent with the rest of the language server, and to fix the undefined variable error.
The dynamically registered providers, like onTypeFormatting, will now work as expected.
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Indirectly fixes #203
Checklist