Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto alignment doesn't work on virtual resources #203

Closed
genebean opened this issue Nov 26, 2019 · 3 comments · Fixed by #376
Closed

Auto alignment doesn't work on virtual resources #203

genebean opened this issue Nov 26, 2019 · 3 comments · Fixed by #376

Comments

@genebean
Copy link
Contributor

What Versions are you running?

OS Version: macOS 10.14.6
VSCode Version: 1.40.1
Puppet Extension Version: 0.21.0
PDK Version: 1.14.1

What You Are Seeing?

While creating a virtual resource no auto alignment happens

What is Expected?

I expect hash rockets to align themselves just like on a normal resource

How Did You Get This To Happen? (Steps to Reproduce)

Create the following resource without copy/paste to see that all alignment must be done manually:

class virtual::users {
  @account::user { 'jdoe':
    comment         => 'J. Doe',
    uid             => 1234,
    group           => 'allstaff',
    groups          => ['developers', 'forge-users', 'modules'],
    shell           => '/bin/bash',
    shared_accounts => ['forgeapi'],
    key             => 'AAAAB3N.../5kWNQ==',
    keytype         => 'ssh-rsa',
  }
}
@glennsarti
Copy link
Contributor

Hrmm... This seems to be working on my computer. Can you explain exactly what you did? e.g. where you clicked and what you pressed on the keyboard

gene

@genebean
Copy link
Contributor Author

genebean commented Dec 9, 2019

This is what I am doing:

virtual-resources-not-aligning

Also, in addition to the recorded attempt above in my normal editor, I tried this in VS Code Insiders 1.41.0-insider where the only plugin I have installed is Puppet 0.21.0... the result was the same. For the insiders instance this is what my user-level settings.json looks like:

{
    "editor.minimap.enabled": false,
    "puppet.editorService.formatOnType.enable": true,
    "editor.formatOnType": true
}

Just in case it matters, note that the file has not been saved in either editor but it was set to use Puppet prior to inserting any code.

@glennsarti
Copy link
Contributor

Hrmm.... stupid computers...I'll try and repro exactly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants