Local packages: fail with appropriate error messages when module or API version are not found#4086
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
provider/pkg/provider/provider_parameterize.go:213
- [nitpick] Consider adding logging or handling for errors returned by resources.ParseToken in getAvailableApiVersions to aid debugging in cases of unexpected token formats.
moduleName, version, _, err := resources.ParseToken(resourceName)
Contributor
Does the PR have any schema changes?Looking good! No breaking changes found. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4086 +/- ##
==========================================
+ Coverage 58.04% 58.08% +0.04%
==========================================
Files 84 84
Lines 13514 13532 +18
==========================================
+ Hits 7844 7860 +16
- Misses 5079 5080 +1
- Partials 591 592 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…PI version are not found
33445e3 to
1667b4b
Compare
danielrbradley
approved these changes
Apr 8, 2025
danielrbradley
left a comment
Contributor
There was a problem hiding this comment.
This looks good, though the test will need updating in #4070
Contributor
|
This PR has been shipped in release v3.1.0. |
This was referenced Sep 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4081 (the error handling part, the rest was resolved by #4082 and #4084).