Skip to content

Local packages: fail with appropriate error messages when module or API version are not found#4086

Merged
thomas11 merged 1 commit into
masterfrom
tkappler/param-fail-better
Apr 8, 2025
Merged

Local packages: fail with appropriate error messages when module or API version are not found#4086
thomas11 merged 1 commit into
masterfrom
tkappler/param-fail-better

Conversation

@thomas11

@thomas11 thomas11 commented Apr 8, 2025

Copy link
Copy Markdown
Contributor

Resolves #4081 (the error handling part, the rest was resolved by #4082 and #4084).

@thomas11 thomas11 requested review from a team, Copilot and danielrbradley April 8, 2025 08:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

provider/pkg/provider/provider_parameterize.go:213

  • [nitpick] Consider adding logging or handling for errors returned by resources.ParseToken in getAvailableApiVersions to aid debugging in cases of unexpected token formats.
moduleName, version, _, err := resources.ParseToken(resourceName)

@github-actions

github-actions Bot commented Apr 8, 2025

Copy link
Copy Markdown
Contributor

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@codecov

codecov Bot commented Apr 8, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Project coverage is 58.08%. Comparing base (9ea3f12) to head (1667b4b).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
provider/pkg/provider/provider_parameterize.go 89.47% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4086      +/-   ##
==========================================
+ Coverage   58.04%   58.08%   +0.04%     
==========================================
  Files          84       84              
  Lines       13514    13532      +18     
==========================================
+ Hits         7844     7860      +16     
- Misses       5079     5080       +1     
- Partials      591      592       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@thomas11 thomas11 force-pushed the tkappler/param-fail-better branch from 33445e3 to 1667b4b Compare April 8, 2025 10:05

@danielrbradley danielrbradley left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, though the test will need updating in #4070

@thomas11 thomas11 enabled auto-merge (squash) April 8, 2025 10:35
@thomas11 thomas11 merged commit 683dcea into master Apr 8, 2025
@thomas11 thomas11 deleted the tkappler/param-fail-better branch April 8, 2025 10:36
@pulumi-bot

Copy link
Copy Markdown
Contributor

This PR has been shipped in release v3.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Explicit API Versions via Local Package for insights only creates a provider resource

4 participants