Skip to content

Bring back erroneously removed Monitor.DiagnosticSetting#4082

Merged
thomas11 merged 2 commits into
masterfrom
tkappler/v3-monitor-diagnosticsettings
Apr 7, 2025
Merged

Bring back erroneously removed Monitor.DiagnosticSetting#4082
thomas11 merged 2 commits into
masterfrom
tkappler/v3-monitor-diagnosticsettings

Conversation

@thomas11

@thomas11 thomas11 commented Apr 6, 2025

Copy link
Copy Markdown
Contributor

I haven't fully understood yet why it was missing. There might be other missing resources and we might need a systematic fix.

  • Re-add erroneously removed Monitor version 2021-05-01-preview
  • regenerate

@thomas11 thomas11 requested review from a team and danielrbradley April 6, 2025 12:02
@github-actions

github-actions Bot commented Apr 6, 2025

Copy link
Copy Markdown
Contributor

Does the PR have any schema changes?

Looking good! No breaking changes found.

New resources:

  • monitor.AutoscaleSetting
  • monitor.DiagnosticSetting
  • monitor.ManagementGroupDiagnosticSetting
  • monitor.SubscriptionDiagnosticSetting

New functions:

  • monitor.getAutoscaleSetting
  • monitor.getDiagnosticSetting
  • monitor.getManagementGroupDiagnosticSetting
  • monitor.getSubscriptionDiagnosticSetting
  • monitor.listDiagnosticSettingsCategory

@codecov

codecov Bot commented Apr 6, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.04%. Comparing base (bcf70a8) to head (a56973a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4082      +/-   ##
==========================================
- Coverage   58.05%   58.04%   -0.01%     
==========================================
  Files          84       84              
  Lines       13514    13514              
==========================================
- Hits         7845     7844       -1     
- Misses       5078     5079       +1     
  Partials      591      591              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@thomas11 thomas11 merged commit 33c6fef into master Apr 7, 2025
@thomas11 thomas11 deleted the tkappler/v3-monitor-diagnosticsettings branch April 7, 2025 08:03
@pulumi-bot

Copy link
Copy Markdown
Contributor

This PR has been shipped in release v3.0.1.

thomas11 added a commit that referenced this pull request Apr 7, 2025
…tor.DataCollection* (#4084)

Fixes #4079 

Similar to #4082, see there for discussion.
thomas11 added a commit that referenced this pull request Apr 8, 2025
…PI version are not found (#4086)

Resolves #4081 (the error handling part, the rest was resolved by #4082
and #4084).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants