Bring back erroneously removed Monitor.DiagnosticSetting#4082
Merged
Conversation
Contributor
Does the PR have any schema changes?Looking good! No breaking changes found. New resources:
New functions:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4082 +/- ##
==========================================
- Coverage 58.05% 58.04% -0.01%
==========================================
Files 84 84
Lines 13514 13514
==========================================
- Hits 7845 7844 -1
- Misses 5078 5079 +1
Partials 591 591 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
danielrbradley
approved these changes
Apr 7, 2025
Contributor
|
This PR has been shipped in release v3.0.1. |
thomas11
added a commit
that referenced
this pull request
Apr 8, 2025
This was referenced Sep 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I haven't fully understood yet why it was missing. There might be other missing resources and we might need a systematic fix.