Revert unreleased spec updates to get Wheel size below 100m#3988
Merged
Conversation
Contributor
Does the PR have any schema changes?Found 87 breaking changes: Resources
Functions
Types
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3988 +/- ##
==========================================
- Coverage 57.51% 57.50% -0.01%
==========================================
Files 82 82
Lines 13092 13092
==========================================
- Hits 7530 7529 -1
- Misses 4986 4987 +1
Partials 576 576 ☔ View full report in Codecov by Sentry. |
danielrbradley
left a comment
danielrbradley
left a comment
Contributor
There was a problem hiding this comment.
Rather than reverting the whole spec upgrade, I think we previously just started adding exclusions so we get updates & fixes to the existing resource versions we're already using, but don't add any new resources to the SDK.
Contributor
Author
True. That seems like a bunch of extra work for a hopefully short-lived situation, though. We can still do a future release with such updates if we need it, which I think isn't very likely. |
thomas11
force-pushed
the
tkappler/exclude-new
branch
from
b3f4540 to
c14d4f1
Compare
danielrbradley
approved these changes
Feb 26, 2025
danielrbradley
left a comment
danielrbradley
left a comment
Contributor
There was a problem hiding this comment.
Yup, this is fine to make the provider releasable as-is to get the associated fixes released. We can re-visit pinning next week if needed.
Contributor
|
This PR has been shipped in release v2.89.0. |
This was referenced Sep 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also reverts "Re-compress the Python Wheel package with bzip2 to shave off 7 MB. (#3982)" which didn't work because Pypi doesn't accept bzip2 even though the Wheel standard allows it.