Re-compress the Python Wheel package with bzip2 to shave off 7 MB.#3982
Merged
Conversation
Contributor
Does the PR have any schema changes?Looking good! No breaking changes found. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3982 +/- ##
=======================================
Coverage 57.49% 57.49%
=======================================
Files 82 82
Lines 13078 13078
=======================================
Hits 7519 7519
Misses 4984 4984
Partials 575 575 ☔ View full report in Codecov by Sentry. |
thomas11
force-pushed
the
tkappler/pypi-compress
branch
2 times, most recently
from
e2da4f6 to
4f1fc10
Compare
thomas11
force-pushed
the
tkappler/pypi-compress
branch
from
4f1fc10 to
b3854a1
Compare
thomas11
force-pushed
the
tkappler/pypi-compress
branch
from
b3854a1 to
ded80e4
Compare
thomas11
force-pushed
the
tkappler/pypi-compress
branch
from
ded80e4 to
518f5b2
Compare
danielrbradley
approved these changes
Feb 25, 2025
danielrbradley
left a comment
danielrbradley
left a comment
Contributor
There was a problem hiding this comment.
Looks like a good approach. Have downloaded the artifact and it looks okay to me too
thomas11
added a commit
that referenced
this pull request
Feb 26, 2025
Also reverts _"Re-compress the Python Wheel package with bzip2 to shave off 7 MB. (#3982)"_ which didn't work because Pypi doesn't accept bzip2 even though the Wheel standard allows it.
Contributor
|
This PR has been shipped in release v2.89.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The provider is currently blocked from releasing the Python SDK because the size of the Wheel package reached 100 MB, see #3977.
While we're waiting on PyPi to increase our limit (if they do), I looked into better compression. Turns out that the package is currently compressed via zip's deflate method, while the better bzip2 would also be valid.
I first tried to use bzip2 directly when building the package, but failed due to pypa/setuptools#2491. This PR instead builds the Wheel as before, then unzips it and re-zips it with bzip2.
A test run shows that it works. The package is 93.8 MB and is uploaded. It fails after upload with The use of local versions in
Version(2.89.0a1740429149+ded80e4)is not allowed but that's because provider-version-action adds the local commit when it's a workflow run that's not on the main branch.