-
-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add copy and "move and organise" features #1143
Draft
AiroPi
wants to merge
10
commits into
pulsejet:master
Choose a base branch
from
AiroPi:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"type" is deprecated, and using "buttonFactory" allow to add more than one button the the modal. Signed-off-by: Pıεяяε <[email protected]>
Signed-off-by: Pıεяяε <[email protected]>
Signed-off-by: airo.pi_ <[email protected]>
Signed-off-by: airo.pi_ <[email protected]>
Signed-off-by: airo.pi_ <[email protected]>
Signed-off-by: airo.pi_ <[email protected]>
Signed-off-by: airo.pi_ <[email protected]>
Signed-off-by: airo.pi_ <[email protected]>
I intended to get to this before the 7.3 release but a hotfix came up that'll need an immediate release. Moving this ahead but 7.4 can come earlier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements features #595 and #1111. It's my first time working with TypeScript, PHP, and Vue, so this is still a draft. I'm aware there are many things that need refactoring.
This adds two new buttons to the "move" modal called “Move and Organize” and "Copy".
To implement these features, I needed to make a few changes:
chooseNcFolder
function slightly. It now takes abuttonFactory
instead oftype
as the third argument.setType
was deprecated anyway ingetFilePickerBuilder
. The default value still behaves the same (providing the "Choose" option) so it doesn't break anything. Other types need to be defined manually.movePhotosByDate
function fordav
. This function first creates the required directories, then moves the files.By the way, the new
copyPhotos
andmovePhotos
functions are very similar and could be merged.