Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pull_request_template.md to ask for related issue or PR numbers #1116

Merged

Conversation

dnsguru
Copy link
Member

@dnsguru dnsguru commented Oct 7, 2020

Added request for submitting party to include historic Issue # or PR # to address issue #1027

  • Description of Organization

  • Reason for PSL Inclusion

  • DNS verification via dig

  • Run Syntax Checker (make test)

  • Each domain listed in the PRIVATE section has and shall maintain at least two years remaining on registration.

Description of Organization

Organization Website:

Reason for PSL Inclusion

DNS Verification via dig

make test

Added request for submitting party to include historic Issue # or PR # to address issue #1027
@dnsguru dnsguru self-assigned this Oct 7, 2020
@dnsguru dnsguru requested a review from sleevi October 7, 2020 16:31
@dnsguru
Copy link
Member Author

dnsguru commented Oct 7, 2020

Fast-follow to #1109 in order to address #1027 (request for submitters to include historic Issue/PR)

@fsodic
Copy link
Contributor

fsodic commented Oct 8, 2020

@sleevi & @dnsguru
I completely disagree. Because it means we have to register the domain for the next 2 years which may add to the costs that are incurred for 1 year of financial statements if from an organization that already has a legal entity.
It might seem okay if the organization is large.
But think again if these organizations only target the local market in their respective countries.
So I think it makes more sense when the domain registered is at least 2 years old from the date of the PR request and not 2 years left since the PR request.
So we know whether the domain is well controlled and not all domains can immediately ask for PR for this publicsuffix.

@dnsguru
Copy link
Member Author

dnsguru commented Oct 8, 2020 via email

@fsodic
Copy link
Contributor

fsodic commented Oct 8, 2020

#1111 my PR not response bro?

@dnsguru
Copy link
Member Author

dnsguru commented Oct 8, 2020 via email

@dnsguru dnsguru changed the title Update pull_request_template.md Update pull_request_template.md to ask for related issue or PR numbers Oct 26, 2020
@dnsguru
Copy link
Member Author

dnsguru commented Oct 26, 2020

@sleevi please approve and s/m

@sleevi sleevi merged commit a3929ae into master Oct 27, 2020
@sleevi sleevi deleted the dnsguru-modify-template-to-include-historic-pr-issues branch October 27, 2020 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants