-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pull request template; private names >2y #1113
Merged
dnsguru
merged 4 commits into
master
from
dnsguru-psl-private-names-expire-term-requirements
Oct 7, 2020
Merged
Update pull request template; private names >2y #1113
dnsguru
merged 4 commits into
master
from
dnsguru-psl-private-names-expire-term-requirements
Oct 7, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to ensure the rationale includes an attestation of >2 years registration term and a commitment to maintaining at least >1 year of registration term per #1109
Added checkboxes to be prominent about requirements
sleevi
reviewed
Oct 6, 2020
I am good with your change, with a tweak.
How about: "..has *and shall maintain* at least.."
My rationale on keeping that ongoing commitment makes it possible for some
later automation to review, flag, comment or remove entries with domains
that have expired or are close to it.
…On Tue, Oct 6, 2020 at 11:58 AM sleevi ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In .github/pull_request_template.md
<#1113 (comment)>:
> +If submission includes entries in the PRIVATE section:
+I attest that:
+* [ ] Domain(s) submitted have 2 or more years before they expire.
+* [ ] I (or my organization) shall maintain the registrations in good standing and will keep the expiry date >1 year at all times.
+* [ ] I understand that my entry could be revoked or rejected where these conditions are not met.
+
Eh, I'm sort of on the fence about the whole "I attest" approach. That
feels very formal and Serious and Heavy Weight and there's not much behind
it.
Perhaps just:
⬇️ Suggested change
-If submission includes entries in the PRIVATE section:
-I attest that:
-* [ ] Domain(s) submitted have 2 or more years before they expire.
-* [ ] I (or my organization) shall maintain the registrations in good standing and will keep the expiry date >1 year at all times.
-* [ ] I understand that my entry could be revoked or rejected where these conditions are not met.
-
+* [ ] Each domain listed in the PRIVATE section has at least two years remaining on registration.
WDYT?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1113 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACQTJLSAWBNNZQHUSQII43SJNSEPANCNFSM4SFJRQBQ>
.
|
Incorporating the consolidated and more friendly suggestion Co-authored-by: sleevi <[email protected]>
Added 'and will maintain'
sleevi
approved these changes
Oct 7, 2020
Thank you @sleevi - can you take a quick peek at and approve #1116 ?
I was sweeping through issues and saw an opportunity to address #1027 while
modifying this, and I'd already SquashMerged #1113
…On Wed, Oct 7, 2020 at 8:42 AM sleevi ***@***.***> wrote:
***@***.**** approved this pull request.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#1113 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACQTJOH3MMFMFRICZWYZYLSJSD6BANCNFSM4SFJRQBQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to ensure the rationale includes an attestation of >2 years registration term and a commitment to maintaining at least >1 year of registration term per #1109
Description of Organization
Organization Website:
Reason for PSL Inclusion
DNS Verification via dig
make test