Activity buttons prompt for thumbnail grids

[oorjitchowdhary]

Fixes #4092
@publiclab/mentors Please review the code now... Thanks a ton 😄
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts
• PR is descriptively titled
• ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

[plotsbot]

	1 Warning
⚠️	It looks like you merged from master in this pull request. Please rebase to get rid of the merge commits – you may want to rewind the master branch and rebase instead of merging in from master, which can cause problems when accepting new code!

	2 Messages
📖	@oorjitchowdhary Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖	It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progresss’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

[vatbq]

You are using a variable that aren't defined. The solve that I found is passing local variables into the parcial. Something like that:
<% render :partial =>"grids/activity_template", locals: { randomSeed: randomSeed } %>

Hope this helps! @oorjitchowdhary

[oorjitchowdhary]

@ValentinaTironi thanks that worked out..
but I'm still lost in few more issues..

1. The add an activity/ask a question code doesn't work when used as a partial template.. If i insert that simply in the code file, it works well..
2. The if questions, elsif activity code isn't working .. Just the embed table shows up when it is deployed..
   I don't what's the fix here.. Kept trying many things, didn't work out..
   @publiclab/reviewers Please help here.

[oorjitchowdhary]

@SidharthBansal No errors now.. but nothing showing up too

[jywarren]

Ah, if it's helpful, wiki pages do not have different types. Only notes.

…

On Sat, Dec 8, 2018 at 4:12 PM Sidharth Bansal ***@***.***> wrote: @SidharthBansal <https://github.com/SidharthBansal> requested your review on: #4175 <#4175> Activity buttons prompt for thumbnail grids. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#4175 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ0ka4R2J_Di4L6bsTE-z6hS6rcCjks5u3DkXgaJpZM4ZJDss> .