-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Activity prompt buttons on Thumbnail grids #4092
Comments
If I can help something, don't hesitate to ask me! |
Impressive work there, @ValentinaTironi |
@jywarren I'm unable to understand this... |
I think he is trying to say that now doesn't exist a button to create notes in thumbnail grid like in others grids. @jywarren Am I right? |
yes, exactly! thanks!!!
…On Sat, Dec 1, 2018 at 1:52 PM Valentina Tironi ***@***.***> wrote:
I think he is trying to say that now doesn't exist a button to create
notes in thumbnail grid like in others grids.
For example, here, in the questions grids there is an ask a question
button
[image: screen shot 2018-12-01 at 3 49 32 pm 1]
<https://user-images.githubusercontent.com/20969831/49331732-c389b100-f580-11e8-9ff2-287f4c04384c.png>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4092 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ0KjGtyu3Y-QmdCC0d8ZFJGE_bHwks5u0s_dgaJpZM4Y9An_>
.
|
@publiclab/reviewers ? |
Sorry for the delay! About your question: I don't see it locally Try create one in your project and let me know if the button appears! |
Yes, i added that button manually! Sorry to confuse you, but we want it
added automatically as in prior types of grids. Thanks!
…On Thu, Dec 6, 2018 at 5:36 PM Valentina Tironi ***@***.***> wrote:
Sorry for the delay! About your question: I don't see it locally
[image: screen shot 2018-12-06 at 7 20 27 pm]
<https://user-images.githubusercontent.com/20969831/49615774-549bc600-f98d-11e8-89ce-731ecbf70b76.png>
Try create one in your project and let me know if the button appears!
@oorjitchowdhary <https://github.com/oorjitchowdhary>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4092 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ10V0Xh4TPZXC4p3ZRZDksVa-PdFks5u2ZvPgaJpZM4Y9An_>
.
|
@oorjitchowdhary are you still working on this? |
Okay.. I'll open a PR in a while.. |
@jywarren How can I make a thumbnail grid like this on localhost? After making a wiki page.. |
You can make a new wiki page, and add the text "[notes:grid:test]" to a new
line in there, and save. That should work!
…On Fri, Dec 7, 2018 at 12:25 PM Oorjit Chowdhary ***@***.***> wrote:
@jywarren <https://github.com/jywarren> How can I make a thumbnail grid
like this on localhost? After making a wiki page..
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4092 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ05N6tkUk3e6HXmJ2FPsNEHpfsX3ks5u2qSBgaJpZM4Y9An_>
.
|
Okay thanks |
That doesn't work @jywarren |
what do you see? You can see examples of thumbnail grids at
https://publiclab.org/micro for reference!
…On Fri, Dec 7, 2018 at 12:46 PM Oorjit Chowdhary ***@***.***> wrote:
That doesn't work @jywarren <https://github.com/jywarren>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4092 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ1fk2qqCtca_jty-sH0TgR2dtL_gks5u2qk-gaJpZM4Y9An_>
.
|
When I use |
Perhaps you don't have any notes tagged with |
Nope, i have it.. 2 of them actually |
what is the exact plaintext content on your wiki page?
…On Fri, Dec 7, 2018 at 1:05 PM Oorjit Chowdhary ***@***.***> wrote:
Nope, i have it.. 2 of them actually
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4092 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ3QIGtX1SlY8QUQH2v6tyT6Hjokfks5u2q3HgaJpZM4Y9An_>
.
|
@jywarren I figured out that one but I'm stuck on another error... 😭 |
This is happening when I try to create a new partial template.. |
Hmm, can you point at your latest code in a commit? Even if you need to
open a new PR to share it? Thanks!
…On Fri, Dec 7, 2018 at 1:34 PM Oorjit Chowdhary ***@***.***> wrote:
This is happening when I try to create a new partial template..
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4092 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ5E1kZP7O8rFX47iqH9gZf8sdVdFks5u2rShgaJpZM4Y9An_>
.
|
Ok i will do that |
And if you've got time pls take a look at #4129 too.. Thanks |
We have some great new features by @ValentinaTironi -- a thumbnail grid -- see the Activities section of https://publiclab.org/micro 👍
One thing that would be great is to have the built-in buttons below that we see on non-thumbnail Activity grids, such as at https://publiclab.org/coqui
Here is the code that auto-generates the button and notice:
plots2/app/views/grids/_notes.html.erb
Lines 66 to 73 in e400bf7
I think we could break it into a partial template and also include it into the new thumbnail template, so we don't have redundant code:
https://github.com/publiclab/plots2/blob/master/app/views/grids/_thumbnail.html.erb
We'd love help with this and it could become a GCI task too!
The text was updated successfully, but these errors were encountered: