-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix map css #11606
base: main
Are you sure you want to change the base?
fix map css #11606
Conversation
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
app/assets/stylesheets/map.css
Outdated
.leaflet-pane{ | ||
position: initial !important; | ||
} | ||
.leaflet-bar, .leaflet-top{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome @itsgurmannatsohal 💯
Maybe you could add the new property of leaflet-top
to line 17, and have the remaining three "positions" on one line since they are similar. What do think?
Thanks for working on this @itsgurmannatsohal ❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I was late. I was caught up in another work. I have made the changes, could you please review?
Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries at all @itsgurmannatsohal , the css file is looking good. Though it looks like the last commit on plots2-main was added on your recent commit - maybe a prob with the rebase?(files changed are now 3). Its no biggie as its the same as we have on main, but it would be cleaner to have only the changes you did on the issue. You could try removing them, but if it becomes a challenge just ping me and I am okay to merge it as is. Thanks again for working on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that is because I synced the plots2/main with my fork. I did that
- To avoid any merge conflicts
- Because the tests were failing when I didn't sync (so I synced and squashed the last two commits).
I can revert them if you'd prefer that.
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
improve-text-for-contributors (publiclab#11532) * improve-text-for-contributors * update * Update en.yml fix indentation * fix indentation * Update en.yml * Update en.yml * Update notes_controller_test.rb * Update notes_controller_test.rb * use line breaks inline --------- Co-authored-by: Ogunbanjo oluwadamilare <[email protected]> Co-authored-by: Cess <[email protected]> Co-authored-by: Tilda Udufo <[email protected]> review fixes
d64cf96
to
ee39a55
Compare
Code Climate has analyzed commit ee39a55 and detected 0 issues on this pull request. View more on Code Climate. |
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
Hi 😄, this issue has been automatically marked as stale because it has not had recent activity. Don't worry you can continue to work on this and ask @publiclab/reviewers to add |
Fixes the map that hovers over footer
Fixes #10306