improve-text-for-contributors #11532
Conversation
|
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #11532 +/- ##
==========================================
- Coverage 83.33% 83.21% -0.13%
==========================================
Files 93 93
Lines 5772 5772
==========================================
- Hits 4810 4803 -7
- Misses 962 969 +7
|
| moderators</a> and we'll email you when it is published. In the meantime, if | ||
| you have more to contribute, feel free to do so." | ||
| thank_you_for_contribution: | | ||
| <h2>Success! You did it! Hooray!</h2> |
There was a problem hiding this comment.
hi @banjo-tech seems there is some syntax error, i guess its indentation - the < of h2 should be indented 2 spaces deep inline with the a in "thank" above, could you please check. Thanks for working on this
There was a problem hiding this comment.
Hi @cesswairimu I do not think I understand what the error is but I have h2 and anchor tag are on the same line now.
There was a problem hiding this comment.
I meant line 1137 maybe should start inline with the a of "thank" on line 1136 ... does that make sense?
There was a problem hiding this comment.
line 1136 doesn't have an anchor tag
are you suggesting I add an anchor tag to line 1136?
There was a problem hiding this comment.
I meant like so 700b639 . Lets see if the tests will pass, thanks
fix indentation
|
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
|
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
|
Hey! is this issue still open? If yes, I would like to work on this. Please assign. |
|
Code Climate has analyzed commit 7396ba6 and detected 0 issues on this pull request. View more on Code Climate. |
|
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
|
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
|
great, thanks @TildaDares |
|
Thanks everyone 💯 |
|
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. You can also join our Gitter channel to connect with other contributors 📥 |
improve-text-for-contributors (publiclab#11532) * improve-text-for-contributors * update * Update en.yml fix indentation * fix indentation * Update en.yml * Update en.yml * Update notes_controller_test.rb * Update notes_controller_test.rb * use line breaks inline --------- Co-authored-by: Ogunbanjo oluwadamilare <[email protected]> Co-authored-by: Cess <[email protected]> Co-authored-by: Tilda Udufo <[email protected]> review fixes
Fixes #11424
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test@publiclab/reviewersfor help, in a comment below