Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 404.html #11495

Closed
wants to merge 1 commit into from
Closed

Update 404.html #11495

wants to merge 1 commit into from

Conversation

liliyao2022
Copy link

Replaced the nav tag with the header tag.

Fixes #0000

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

Replaced the nav tag with the header tag.
@welcome
Copy link

welcome bot commented Oct 17, 2022

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄


One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000 (for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! 🙌


Then, you can say hello in our chatroom & share a link to this PR to get a review! 👋 ✅

@gitpod-io
Copy link

gitpod-io bot commented Oct 17, 2022

@liliyao2022
Copy link
Author

replaced the nav tag with the header tag.

@codeclimate
Copy link

codeclimate bot commented Oct 17, 2022

Code Climate has analyzed commit 8db22fd and detected 0 issues on this pull request.

View more on Code Climate.

@liliyao2022 liliyao2022 mentioned this pull request Oct 17, 2022
@github-actions
Copy link

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/8800897261/artifacts/400190952

@@ -17,13 +17,13 @@

<body>

<nav id="header" class="navbar navbar-dark bg-dark fixed-top mb-5 py-3">
<hearder id="header" class="navbar navbar-dark bg-dark fixed-top mb-5 py-3">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<hearder id="header" class="navbar navbar-dark bg-dark fixed-top mb-5 py-3">
<header id="header" class="navbar navbar-dark bg-dark fixed-top mb-5 py-3">

<div class="container">
<div class="navbar-header">
<a class="navbar-brand ml-lg-5" id="brand" href="/">Public Lab</a>
</div>
</div>
</nav>
</hearder>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
</hearder>
</header>

@TildaDares
Copy link
Member

Hi @liliyao2022, can you add a link to the issue?

One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the
format fixes #0000 (for example)

@TildaDares
Copy link
Member

Thank you for taking the time to work on this PR but the issue has been resolved in #11539.

@TildaDares TildaDares closed this Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants