-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 404.html #11495
Update 404.html #11495
Conversation
Replaced the nav tag with the header tag.
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
replaced the nav tag with the header tag. |
Code Climate has analyzed commit 8db22fd and detected 0 issues on this pull request. View more on Code Climate. |
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
@@ -17,13 +17,13 @@ | |||
|
|||
<body> | |||
|
|||
<nav id="header" class="navbar navbar-dark bg-dark fixed-top mb-5 py-3"> | |||
<hearder id="header" class="navbar navbar-dark bg-dark fixed-top mb-5 py-3"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<hearder id="header" class="navbar navbar-dark bg-dark fixed-top mb-5 py-3"> | |
<header id="header" class="navbar navbar-dark bg-dark fixed-top mb-5 py-3"> |
<div class="container"> | ||
<div class="navbar-header"> | ||
<a class="navbar-brand ml-lg-5" id="brand" href="/">Public Lab</a> | ||
</div> | ||
</div> | ||
</nav> | ||
</hearder> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
</hearder> | |
</header> |
Hi @liliyao2022, can you add a link to the issue?
|
Thank you for taking the time to work on this PR but the issue has been resolved in #11539. |
Replaced the nav tag with the header tag.
Fixes #0000
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment below