Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility #11494

Closed
Natacha-Danbadan opened this issue Oct 16, 2022 · 17 comments · Fixed by #11539
Closed

Accessibility #11494

Natacha-Danbadan opened this issue Oct 16, 2022 · 17 comments · Fixed by #11539
Labels

Comments

@Natacha-Danbadan
Copy link
Contributor

This issue aims to improve the accessibility of the html pages (Semantic HTML) and fix the position of the scripts to Keep up with best practices. This to enable web crawlers and users in general to be able to access the site's content regardless of a user's impairment. For example replace the nav tag with the header tag, have a main tag in all html files, position the script tag inside of the body as some are positioned out of the body. This would be done to all html files contained in the repo below.

https://github.com/publiclab/plots2/tree/main/public

screencapture-github-publiclab-plots2-blob-master-public-404-html-2022-10-16-20_58_31

@welcome
Copy link

welcome bot commented Oct 16, 2022

Thanks for opening your first issue! This space is protected by our Code of Conduct - and we're here to help.
Please follow the issue template to help us help you 👍🎉😄
If you have screenshots or a gif to share demonstrating the issue, that's really helpful! 📸
Do join our Gitter channel for some brainstorming discussions.

@liliyao2022
Copy link

Hi, I'd like to try.

@liliyao2022
Copy link

@vareenrose
Copy link

I'd like to do this for the rest of the html files

@Natacha-Danbadan
Copy link
Contributor Author

Hi, the issue has'nt been approved yet.

@TildaDares
Copy link
Member

Hi @Natacha-Danbadan, thank you for opening this issue. Your suggestion is very good and will help improve the accessibility of the site. Can you make a list of all the files that need this change? Thank you!

@Natacha-Danbadan
Copy link
Contributor Author

Natacha-Danbadan commented Oct 21, 2022

The first set of HTML files can be found in the plots2 repo public folder, https://github.com/publiclab/plots2/tree/main/public
404.html
422.html
500.html
502.html
503.html

The second set of HTML files can be found in the leaflet.distortableImage repo examples folder, https://github.com/publiclab/Leaflet.DistortableImage/tree/main/examples
archive.html
export.html
index.html
listeners.html
select.html

@TildaDares
Copy link
Member

Hi @Natacha-Danbadan, this repo has a lot of HTML files but most of them don't have the normal HTML boilerplate. Can you add a list of the files with the HTML boilerplate so I can review them? Thanks!

@Natacha-Danbadan
Copy link
Contributor Author

Yes @TildaDares I have just done that. I'm still expecting an FTO issue. Thank you ma'am.

@TildaDares
Copy link
Member

Hi @Natacha-Danbadan, the other HTML files in here https://github.com/publiclab/plots2/tree/main/public apart from 404.html also need this change. Maybe you could work on that. Thanks!

@Natacha-Danbadan
Copy link
Contributor Author

Yes ma'am, I also stated the other HTML files that need to be worked on in my previous message. I'll get started on that ASAP. Thanks ma'am.

@Natacha-Danbadan
Copy link
Contributor Author

so while working on the accessibility on the HTML files , i discovered there was no base tag on the head tag, is there a a Default URL and a default target for all links on a page you would like me to add on the HTML base tag? @TildaDares @jywarren @PeculiarE

@TildaDares
Copy link
Member

Hi @Natacha-Danbadan, setting a base tag now would mean having to change all the internal links in the project. That would be too big a task to complete before the contribution period ends. Thank you!

@Natacha-Danbadan
Copy link
Contributor Author

Okay ma'am, duly noted.

@Natacha-Danbadan
Copy link
Contributor Author

Natacha-Danbadan commented Oct 24, 2022

@TildaDares @cesswairimu @jywarren kindly help review my PR for the Plots2 repo. #11539

@Natacha-Danbadan
Copy link
Contributor Author

@TildaDares @cesswairimu @jywarren kindly help review my PR for the Leaflet.DistortableImage Repo
publiclab/Leaflet.DistortableImage#1234

@amarachi-nwokocha
Copy link
Contributor

Hi @Natacha-Danbadan is this issue taken id love to work on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants