Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Authlogic deprecation warning for email validation #5125

Closed
4 tasks
cesswairimu opened this issue Mar 17, 2019 · 1 comment
Closed
4 tasks

Remove Authlogic deprecation warning for email validation #5125

cesswairimu opened this issue Mar 17, 2019 · 1 comment
Labels
assigned first-timers-only They need to be well-formatted using the First-timers_Issue_Template.

Comments

@cesswairimu
Copy link
Collaborator

Main issue #4624
created specifically for @CubikMan47

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

Problem:
There is this Authlogic deprecation warning currently

DEPRECATION WARNING: This Authlogic configuration option (validates_format_of_email_field_options) is deprecated. Use normal
ActiveRecord validation instead.

📝 Update:

After changing run the tests and make sure the deprecation warning is gone.

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Leave a comment below!
@cesswairimu cesswairimu added the first-timers-only They need to be well-formatted using the First-timers_Issue_Template. label Mar 17, 2019
@cesswairimu cesswairimu mentioned this issue Mar 17, 2019
Closed
58 tasks
@esposm03
Copy link
Contributor

Alright, thanks!

This was referenced Mar 17, 2019
Closed
Closed
@Julius26 Julius26 mentioned this issue Mar 18, 2019
Closed
5 tasks
@esposm03 esposm03 mentioned this issue Mar 18, 2019
Merged
5 tasks
grvsachdeva pushed a commit that referenced this issue Mar 18, 2019
@esposm03 @grvsachdeva
Fix Authlogic deprecation for email validation (#5155)
34758a3 
* Remove Authlogic deprecation warning for email validation (#5125)

* Update 'user with wrong email' test

* Update 'user with wrong email' test

Assert doesn't use an hard-coded number of errors anymore
icarito pushed a commit to icarito/plots2 that referenced this issue Apr 9, 2019
@esposm03 @icarito
Fix Authlogic deprecation for email validation (publiclab#5155)
1743cea 
* Remove Authlogic deprecation warning for email validation (publiclab#5125)

* Update 'user with wrong email' test

* Update 'user with wrong email' test

Assert doesn't use an hard-coded number of errors anymore
SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this issue May 5, 2019
@esposm03 @grvsachdeva
Fix Authlogic deprecation for email validation (publiclab#5155)
34be281 
* Remove Authlogic deprecation warning for email validation (publiclab#5125)

* Update 'user with wrong email' test

* Update 'user with wrong email' test

Assert doesn't use an hard-coded number of errors anymore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
assigned first-timers-only They need to be well-formatted using the First-timers_Issue_Template.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cesswairimu @esposm03