Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance frontend of providers #574

Open
SidharthBansal opened this issue May 1, 2019 · 24 comments
Open

Enhance frontend of providers #574

SidharthBansal opened this issue May 1, 2019 · 24 comments
Labels
fto-candidate

Comments

@SidharthBansal
Copy link
Member

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.
Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step
🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

📝 Update
Enhance Login provider buttons[fb, twitter, github, google]

Code link: app/views/layout/_login_form.html.erb

Earlier

image

💾 Commit your changes

🔀 Start a Pull Request. There are two ways how you can start a pull request:

If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

You can also edit files directly in your browser and open a pull request from there.

🏁 Done Ask in comments for a review :)
Please keep us updated
💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?
🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?
Leave a comment below!
Part of #381
@SidharthBansal SidharthBansal mentioned this issue May 1, 2019
Closed
58 tasks
@benfanderson
Copy link

Claimed. I'll fork the repository, have a look and then ask you some questions. Thanks so much.

@SidharthBansal
Copy link
Member Author

SidharthBansal commented May 1, 2019 via email

@benfanderson
Copy link

Okay, I have forked and cloned the repo. First question: Should I name my new branch something like button-enhance-574 so it's obvious which issue I am dealing with?

@SidharthBansal
Copy link
Member Author

SidharthBansal commented May 1, 2019 via email

@benfanderson
Copy link

Done. I need to upgrade Ruby and instal Rails on my new machine. While I do that are you able to give me an idea of what you mean by enhancing the provider buttons? Does that men changing the CSS styles? Sorry if this is a rookie question, I am still very new at this.

@SidharthBansal
Copy link
Member Author

SidharthBansal commented May 2, 2019 via email

@benfanderson
Copy link

Hi, i am having some trouble getting the right gems installed but once I have done that I'll get stuck into it.

@SidharthBansal
Copy link
Member Author

SidharthBansal commented May 3, 2019 via email

@benfanderson
Copy link

Hi, when I try to launch the rails server rails s I get the following error:

DEPRECATION WARNING: Support for Rails versions before 4.2 is deprecated and will be removed from skylight 2.0.

Should I upgrade the rails gem in the gemfile to 4.2.0?

@SidharthBansal
Copy link
Member Author

SidharthBansal commented May 5, 2019 via email

@benfanderson
Copy link

benfanderson commented May 6, 2019 •
edited
Loading

Hi, I used rvm to create a gemset with ruby version of 2.4.6 and a rails version of 2.4.0 and tried to switch to that but when I run rails -v I am still getting Rails 3.2.22.5.

Here is the full error message when I run rails s:

DEPRECATION WARNING: Support for Rails versions before 4.2 is deprecated and will be removed from skylight 2.0. (called from require at /Users/bena/.rvm/rubies/ruby-2.4.6/lib/ruby/site_ruby/2.4.0/bundler/runtime.rb:81)
=> Booting WEBrick
=> Rails 3.2.22.5 application starting in development on http://0.0.0.0:3000
=> Call with -d to detach
=> Ctrl-C to shutdown server
[SKYLIGHT] [1.7.2] Running Skylight in development mode. No data will be reported until you deploy your app.
(To disable this message for all local apps, run `skylight disable_dev_warning`.)
Exiting
/Users/bena/.rvm/gems/ruby-2.4.6/gems/railties-3.2.22.5/lib/rails/application/configuration.rb:115:in `read': No such file or directory @ rb_sysopen - /Users/bena/Documents/repos/ben-repos/mapknitter/config/database.yml (Errno::ENOENT)
	from /Users/bena/.rvm/gems/ruby-2.4.6/gems/railties-3.2.22.5/lib/rails/application/configuration.rb:115:in `database_configuration'
	from /Users/bena/.rvm/gems/ruby-2.4.6/gems/activerecord-3.2.22.5/lib/active_record/railtie.rb:84:in `block (2 levels) in <class:Railtie>'
	from /Users/bena/.rvm/gems/ruby-2.4.6/gems/activesupport-3.2.22.5/lib/active_support/lazy_load_hooks.rb:36:in `instance_eval'
	from /Users/bena/.rvm/gems/ruby-2.4.6/gems/activesupport-3.2.22.5/lib/active_support/lazy_load_hooks.rb:36:in `execute_hook'
	from /Users/bena/.rvm/gems/ruby-2.4.6/gems/activesupport-3.2.22.5/lib/active_support/lazy_load_hooks.rb:43:in `block in run_load_hooks'
	from /Users/bena/.rvm/gems/ruby-2.4.6/gems/activesupport-3.2.22.5/lib/active_support/lazy_load_hooks.rb:42:in `each'
	from /Users/bena/.rvm/gems/ruby-2.4.6/gems/activesupport-3.2.22.5/lib/active_support/lazy_load_hooks.rb:42:in `run_load_hooks'
	from /Users/bena/.rvm/gems/ruby-2.4.6/gems/activerecord-3.2.22.5/lib/active_record/base.rb:720:in `<top (required)>'
	from /Users/bena/.rvm/gems/ruby-2.4.6/gems/skylight-1.7.2/lib/skylight/probes.rb:119:in `require'
	from /Users/bena/.rvm/gems/ruby-2.4.6/gems/skylight-1.7.2/lib/skylight/probes.rb:119:in `require'
	from /Users/bena/.rvm/gems/ruby-2.4.6/gems/activesupport-3.2.22.5/lib/active_support/dependencies.rb:251:in `block in require'
	from /Users/bena/.rvm/gems/ruby-2.4.6/gems/activesupport-3.2.22.5/lib/active_support/dependencies.rb:236:in `load_dependency'
	from /Users/bena/.rvm/gems/ruby-2.4.6/gems/activesupport-3.2.22.5/lib/active_support/dependencies.rb:251:in `require'
	from /Users/bena/Documents/repos/ben-repos/mapknitter/config/initializers/column_definition.rb:19:in `<class:ColumnDefinition>'
	from /Users/bena/Documents/repos/ben-repos/mapknitter/config/initializers/column_definition.rb:17:in `<top (required)>'
	from /Users/bena/.rvm/gems/ruby-2.4.6/gems/activesupport-3.2.22.5/lib/active_support/dependencies.rb:245:in `load'
	from /Users/bena/.rvm/gems/ruby-2.4.6/gems/activesupport-3.2.22.5/lib/active_support/dependencies.rb:245:in `block in load'
	from /Users/bena/.rvm/gems/ruby-2.4.6/gems/activesupport-3.2.22.5/lib/active_support/dependencies.rb:236:in `load_dependency'
	from /Users/bena/.rvm/gems/ruby-2.4.6/gems/activesupport-3.2.22.5/lib/active_support/dependencies.rb:245:in `load'
	from /Users/bena/.rvm/gems/ruby-2.4.6/gems/railties-3.2.22.5/lib/rails/engine.rb:593:in `block (2 levels) in <class:Engine>'
	from /Users/bena/.rvm/gems/ruby-2.4.6/gems/railties-3.2.22.5/lib/rails/engine.rb:592:in `each'
	from /Users/bena/.rvm/gems/ruby-2.4.6/gems/railties-3.2.22.5/lib/rails/engine.rb:592:in `block in <class:Engine>'
	from /Users/bena/.rvm/gems/ruby-2.4.6/gems/railties-3.2.22.5/lib/rails/initializable.rb:30:in `instance_exec'
	from /Users/bena/.rvm/gems/ruby-2.4.6/gems/railties-3.2.22.5/lib/rails/initializable.rb:30:in `run'
	from /Users/bena/.rvm/gems/ruby-2.4.6/gems/railties-3.2.22.5/lib/rails/initializable.rb:55:in `block in run_initializers'
	from /Users/bena/.rvm/gems/ruby-2.4.6/gems/railties-3.2.22.5/lib/rails/initializable.rb:54:in `each'
	from /Users/bena/.rvm/gems/ruby-2.4.6/gems/railties-3.2.22.5/lib/rails/initializable.rb:54:in `run_initializers'
	from /Users/bena/.rvm/gems/ruby-2.4.6/gems/railties-3.2.22.5/lib/rails/application.rb:136:in `initialize!'
	from /Users/bena/.rvm/gems/ruby-2.4.6/gems/railties-3.2.22.5/lib/rails/railtie/configurable.rb:30:in `method_missing'
	from /Users/bena/Documents/repos/ben-repos/mapknitter/config/environment.rb:5:in `<top (required)>'
	from /Users/bena/.rvm/gems/ruby-2.4.6/gems/skylight-1.7.2/lib/skylight/probes.rb:119:in `require'
	from /Users/bena/.rvm/gems/ruby-2.4.6/gems/skylight-1.7.2/lib/skylight/probes.rb:119:in `require'
	from /Users/bena/Documents/repos/ben-repos/mapknitter/config.ru:3:in `block in <main>'
	from /Users/bena/.rvm/gems/ruby-2.4.6/gems/rack-1.4.7/lib/rack/builder.rb:51:in `instance_eval'
	from /Users/bena/.rvm/gems/ruby-2.4.6/gems/rack-1.4.7/lib/rack/builder.rb:51:in `initialize'
	from /Users/bena/Documents/repos/ben-repos/mapknitter/config.ru:in `new'
	from /Users/bena/Documents/repos/ben-repos/mapknitter/config.ru:in `<main>'
	from /Users/bena/.rvm/gems/ruby-2.4.6/gems/rack-1.4.7/lib/rack/builder.rb:40:in `eval'
	from /Users/bena/.rvm/gems/ruby-2.4.6/gems/rack-1.4.7/lib/rack/builder.rb:40:in `parse_file'
	from /Users/bena/.rvm/gems/ruby-2.4.6/gems/rack-1.4.7/lib/rack/server.rb:200:in `app'
	from /Users/bena/.rvm/gems/ruby-2.4.6/gems/railties-3.2.22.5/lib/rails/commands/server.rb:46:in `app'
	from /Users/bena/.rvm/gems/ruby-2.4.6/gems/rack-1.4.7/lib/rack/server.rb:304:in `wrapped_app'
	from /Users/bena/.rvm/gems/ruby-2.4.6/gems/rack-1.4.7/lib/rack/server.rb:254:in `start'
	from /Users/bena/.rvm/gems/ruby-2.4.6/gems/railties-3.2.22.5/lib/rails/commands/server.rb:70:in `start'
	from /Users/bena/.rvm/gems/ruby-2.4.6/gems/railties-3.2.22.5/lib/rails/commands.rb:55:in `block in <top (required)>'
	from /Users/bena/.rvm/gems/ruby-2.4.6/gems/railties-3.2.22.5/lib/rails/commands.rb:50:in `tap'
	from /Users/bena/.rvm/gems/ruby-2.4.6/gems/railties-3.2.22.5/lib/rails/commands.rb:50:in `<top (required)>'
	from script/rails:6:in `require'
	from script/rails:6:in `<main>'

Am I missing something?

@SidharthBansal
Copy link
Member Author

SidharthBansal commented May 6, 2019 via email

@benfanderson
Copy link

benfanderson commented May 6, 2019 •
edited
Loading

Sorry, I am still getting the same error message.
I am using ruby 2.4.6p354 and rails 3.2.22.55. Are they the correct versions? I can't seem to change them.

@SidharthBansal
Copy link
Member Author

SidharthBansal commented May 6, 2019 via email

@SidharthBansal
Copy link
Member Author

Please do bundle install.
I think there is some problem there.
You can see the versions required in the gemfile.

@benfanderson
Copy link

Just letting you know I have sorted out my gem issues and I will be able to get started on the html/css stuff soon. Thanks for your patience.

@SidharthBansal
Copy link
Member Author

SidharthBansal commented May 8, 2019 via email

@SidharthBansal SidharthBansal mentioned this issue May 8, 2019
Closed
12 tasks
@SidharthBansal
Copy link
Member Author

Hi, just checking if you've gotten stuck on this at all, or if I could help in any way? Thanks!

@benfanderson
Copy link

benfanderson commented May 13, 2019 •
edited
Loading

Hi I am still getting stuck on launching the app.
whenever I try to run rake db:setup I get the following error

LoadError: Please install the mysql2 adapter: `gem install activerecord-mysql2-adapter` (cannot load such file -- mysql2/mysql2)

I have tried installing the activerecord-mysql2-adapter gem but the error remains.
The adapters in my database.yml file are all mysql2
I am running Ruby 2.4.6p354 and Rails 3.2.22.5

@SidharthBansal
Copy link
Member Author

image
Please do like this.
Add your system password in the password field. I hope it works.

@benfanderson
Copy link

benfanderson commented May 13, 2019 •
edited
Loading

Sorry, i did that but I am still getting the same error message. when I I do gem list I can't see activerecord-mysql2-adapter anywhere in the list but when I do gem list activerecord-mysql2-adapter I get

*** LOCAL GEMS ***

activerecord-mysql2-adapter (0.0.3)

Sorry this is taking so long. I know a fair bit about CSS/HTML so the main task is straightforward, I just can't seem to get the app up and running.

@SidharthBansal
Copy link
Member Author

SidharthBansal commented May 13, 2019 via email

@benfanderson
Copy link

Hi, I don't want to hold up things here so feel free to give this task to someone else. Thanks for your patience.

@grvsachdeva
Copy link
Member

Hi @benfanderson, no issues. Are you still getting this - #574 (comment) error while running rake db:setup?. Also, please pull the latest main branch as we are continuously updating the main branch. Thanks!

@willow19 willow19 mentioned this issue Apr 22, 2021
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fto-candidate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@grvsachdeva @SidharthBansal @benfanderson