Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #265 +/- ##
=======================================
Coverage 87.43% 87.43%
=======================================
Files 11 11
Lines 1973 1973
Branches 243 243
=======================================
Hits 1725 1725
Misses 166 166
Partials 82 82 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR promotes develop to main, bringing in an offline codegen drift guard (to catch emitter/source-data changes that aren’t regenerated in the same PR) and updates to local lint tooling and contributor workflow documentation.
Changes:
- Add
--skip-download/ offline mode toLanguageTagsCreateto regenerate from committedLanguageData/without fetching upstream registries. - Add a
codegen-driftGitHub Actions job to regenerate + format + fail on any tree drift. - Add VS Code Docker-based lint tasks (with
--pull=always) and adjust pre-commit behavior/documentation to match the intended local/CI split.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| LanguageTagsCreate/Program.cs | Branch between online download and offline “use committed data” mode. |
| LanguageTagsCreate/CreateTagData.cs | Factor path resolution; add UseExistingData() validation for offline regen. |
| LanguageTagsCreate/CommandLine.cs | Add --skip-download (-s) CLI option and plumb through to execution. |
| AGENTS.md | Document offline regeneration workflow and clarify local lint tooling approach. |
| .vscode/tasks.json | Add Docker-based “Lint:*” tasks and a “Lint: All” aggregator with --pull=always. |
| .husky/pre-commit | Make pre-commit hook conditional on dotnet presence and update comments. |
Comment on lines
+84
to
+85
| - name: Check EditorConfig step | ||
| run: docker run --rm -v "$PWD":/check --workdir /check mstruebing/editorconfig-checker:latest |
Comment on lines
+7
to
+9
| if command -v dotnet >/dev/null 2>&1; then | ||
| dotnet husky run | ||
| fi |
Comment on lines
+71
to
+74
| throw new FileNotFoundException( | ||
| $"Required data file does not exist: {dataFile}", | ||
| dataFile | ||
| ); |
This was referenced Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward promotion of #264 (and prior conformance work). No release (human merge).