conformance: codecov.yml + husky/VS Code lint parity with CI#256
Closed
ptr727 wants to merge 2 commits into
Closed
conformance: codecov.yml + husky/VS Code lint parity with CI#256ptr727 wants to merge 2 commits into
ptr727 wants to merge 2 commits into
Conversation
- codecov.yml: coverage reported, never gated (informational project+patch), so a coverage delta can't block a PR - .husky/pre-commit: run the CI lint set (editorconfig-checker, actionlint, markdownlint, cspell) via Docker, present-only so it never false-blocks - .vscode/tasks.json: a Lint group mirroring CI that warms the hook's images Mirrors ProjectTemplate #273 (codecov) + #276 (lint parity). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #256 +/- ##
========================================
Coverage 99.76% 99.76%
========================================
Files 15 15
Lines 232994 232994
Branches 243 243
========================================
Hits 232450 232450
Misses 462 462
Partials 82 82 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds repo conformance plumbing for coverage reporting (Codecov) and for local lint parity with CI via Husky pre-commit and VS Code tasks, aiming to reduce CI-only surprises while keeping coverage non-gating.
Changes:
- Add
codecov.ymlto make Codecov project/patch statuses informational (non-blocking). - Extend
.husky/pre-committo optionally run CI-like linters via Docker when images are already present. - Add a language-agnostic “Lint” task group in
.vscode/tasks.jsonto mirror CI and warm the hook’s Docker images.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
codecov.yml |
Adds Codecov configuration to trend coverage without gating PRs. |
.vscode/tasks.json |
Adds “Lint” tasks to run editorconfig-checker/actionlint/markdownlint/cspell via Docker. |
.husky/pre-commit |
Adds optional Docker-based lint steps for local CI parity when images are available. |
…to README+HISTORY, reword Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Comment on lines
+158
to
+162
| { | ||
| "label": "Lint: Workflows", | ||
| "type": "shell", | ||
| "command": "docker run --rm -v \"${workspaceFolder}:/repo\" -w /repo rhysd/actionlint:latest -color", | ||
| "problemMatcher": [], |
Comment on lines
+168
to
+182
| { | ||
| "label": "Lint: Markdown", | ||
| "type": "shell", | ||
| "command": "docker run --rm -v \"${workspaceFolder}:/workdir\" -w /workdir davidanson/markdownlint-cli2:latest \"**/*.md\"", | ||
| "problemMatcher": [], | ||
| "presentation": { | ||
| "showReuseMessage": false, | ||
| "clear": false | ||
| } | ||
| }, | ||
| { | ||
| "label": "Lint: Spelling", | ||
| "type": "shell", | ||
| "command": "docker run --rm -v \"${workspaceFolder}:/workdir\" -w /workdir ghcr.io/streetsidesoftware/cspell:latest --no-progress README.md HISTORY.md", | ||
| "problemMatcher": [], |
Comment on lines
+30
to
+33
| # Workflow YAML (plus embedded run: shell via bundled shellcheck) when a workflow file is staged. | ||
| if printf '%s\n' "$staged" | grep -Eq '^\.github/workflows/.*\.ya?ml$'; then | ||
| lint rhysd/actionlint:latest -color | ||
| fi |
Comment on lines
+35
to
+39
| # Markdown lint + spelling (word list + exclusions from cspell.json) when a Markdown file is staged. | ||
| if printf '%s\n' "$staged" | grep -q '\.md$'; then | ||
| lint davidanson/markdownlint-cli2:latest "**/*.md" | ||
| lint ghcr.io/streetsidesoftware/cspell:latest --no-progress README.md HISTORY.md | ||
| fi |
Owner
Author
|
Superseded by #262, which converges LanguageTags onto the new per-surface lint architecture (CI action wrappers incl. editorconfig-checker, language-only hook, VS Code doc-lint via Docker :latest). This PR's docker-linters-in-the-hook approach is retired, and codecov.yml already landed on develop via #260. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bundled conformance backfill (per the fleet lint-parity + coverage-hygiene work).
informationalproject+patch), distinct from the upload step'sfail_ci_if_error: false.Mirrors ProjectTemplate #273 (codecov standard) and #276 (lint parity). editorconfig-checker + sh -n clean locally.
🤖 Generated with Claude Code