Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not add trailing commas to return type annotations using PEP 604 unions #3735

Merged
merged 1 commit into from
Jun 16, 2023
Merged

Do not add trailing commas to return type annotations using PEP 604 unions #3735

merged 1 commit into from
Jun 16, 2023

Conversation

yilei
Copy link
Contributor

@yilei yilei commented Jun 15, 2023

Description

Fix #3638

Checklist - did you ...

  • Add an entry in CHANGES.md if necessary?
  • Add / update tests if necessary?
  • Add new / update outdated documentation?

@JelleZijlstra JelleZijlstra self-requested a review June 15, 2023 22:57
@github-actions
Copy link

diff-shades reports zero changes comparing this PR (0ce244d) to main (35722df).

What is this? | Workflow run | diff-shades documentation

@JelleZijlstra JelleZijlstra merged commit 01b8d3d into psf:main Jun 16, 2023
@copybara-service copybara-service bot mentioned this pull request Jun 16, 2023
Closed
copybara-service bot pushed a commit to google/pyink that referenced this pull request Jun 16, 2023
@yilei @copybara-github
Cherry pick psf#3735.
a733067 
Why not rebase? Black has unreleased changes in blib2to3, rebasing will make Pyink releases harder. Will wait for a new Black release before we rebase.

PiperOrigin-RevId: 540903043
copybara-service bot pushed a commit to google/pyink that referenced this pull request Jun 16, 2023
@yilei @copybara-github
Cherry pick psf#3735.
853edc8 
Why not rebase? Black has unreleased changes in blib2to3, rebasing will make Pyink releases harder. Will wait for a new Black release before we rebase.

PiperOrigin-RevId: 540903043
copybara-service bot pushed a commit to google/pyink that referenced this pull request Jun 16, 2023
@yilei @copybara-github
Cherry pick psf#3735.
5537355 
Why not rebase? Black has unreleased changes in blib2to3, rebasing will make Pyink releases harder. Will wait for a new Black release before we rebase.

PiperOrigin-RevId: 540903043
copybara-service bot pushed a commit to google/pyink that referenced this pull request Jun 16, 2023
@yilei @copybara-github
Cherry pick psf#3735.
8f04b3c 
Why not rebase? Black has unreleased changes in blib2to3, rebasing will make Pyink releases harder. Will wait for a new Black release before we rebase.

PiperOrigin-RevId: 540999761
@yilei yilei deleted the annret branch October 18, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Black adds unexpected trailing comma in return type wrapped in parenthesis
2 participants
@yilei @JelleZijlstra