Skip to content

Commit

Permalink
Cherry pick psf#3735.
Browse files Browse the repository at this point in the history
Why not rebase? Black has unreleased changes in blib2to3, rebasing will make Pyink releases harder. Will wait for a new Black release before we rebase.

PiperOrigin-RevId: 540903043
  • Loading branch information
yilei authored and copybara-github committed Jun 16, 2023
1 parent 0cc6825 commit 5537355
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 1 deletion.
16 changes: 15 additions & 1 deletion patches/pyink.patch
Original file line number Diff line number Diff line change
Expand Up @@ -681,7 +681,21 @@
if leaves:
# Since body is a new indent level, remove spurious leading whitespace.
normalize_prefix(leaves[0], inside_brackets=True)
@@ -1449,7 +1551,7 @@ def generate_trailers_to_omit(line: Line
@@ -915,6 +1017,13 @@ def bracket_split_build_line(
)
if isinstance(node, Node) and isinstance(node.prev_sibling, Leaf)
)
+ # Except the false negatives above for PEP 604 unions where we
+ # can't add the comma.
+ and not (
+ leaves[0].parent
+ and leaves[0].parent.next_sibling
+ and leaves[0].parent.next_sibling.type == token.VBAR
+ )
)

if original.is_import or no_commas:
@@ -1449,7 +1558,7 @@ def generate_trailers_to_omit(line: Line
if not line.magic_trailing_comma:
yield omit

Expand Down
7 changes: 7 additions & 0 deletions src/pyink/linegen.py
Original file line number Diff line number Diff line change
Expand Up @@ -1008,6 +1008,13 @@ def bracket_split_build_line(
)
if isinstance(node, Node) and isinstance(node.prev_sibling, Leaf)
)
# Except the false negatives above for PEP 604 unions where we
# can't add the comma.
and not (
leaves[0].parent
and leaves[0].parent.next_sibling
and leaves[0].parent.next_sibling.type == token.VBAR
)
)

if original.is_import or no_commas:
Expand Down

0 comments on commit 5537355

Please sign in to comment.