Fixes july #287
Fixes july #287
Conversation
- Remove guiDelay - Fix guiIntroLoop - move all audsrv* code into sound driver
This is how we are freeing SPU buffers to reload SFX for custom themes
…date duration calculation function
|
Please revert "switch from clock to ps2_clock function". The issue with clock() should now be solved in ps2sdk. Can you verify the issues are gone with the updated clock function? Next time please try to find the root-cause of issues instead of working your way around them. The commits in this PR both change things and then revert some of the same things. I think these should be squashed before creating the PR, but I understand these git operations are not easy for everyone. Instead I suggest we squash-merge this PR if it gets pulled/approved. Also try to be more descriptive of your PR's. Becouse "Fixes july" does not tell me anything about this PR. What does this fix? What was broke? The description also does not describe this. |
|
Also I am not a professional programmer.. I’ve been bangin on about clock() for over a week now; there is no way I would’ve been able to find the cause.. only steer someone else in the right direction, which I tried to do only to have you mocking me each time.
You appear to have some sort of chip on your shoulder in regards to me, I suggest you get over whatever issue you have as at this point I just find the shit comical. |
|
done.. this: ps2dev/ps2sdk#133 does indeed fix all issues related to the clock().. thank you for taking the time to look at it.. |
It's perfectly fine if you're not a professional programmer, as long as the quality of the end result is acceptable. I'm always trying to be constructive towards everyone. I'm not just telling you something is bad. I'm also telling you why and how it can be done differently. I'm not 'mocking' you each time, but I'm trying to help, each time. I hope you and others learn from it, and if I'm wrong in my comments then I hope you'll tell me otherwise and I can learn from you.
The only problem I have recently is a lack of time. So instead of fixing problems like these I'm hoping others, like you, can find the root-couse of this issue and fix it. Working around issues will not make the build more stable. Becouse the issues are probably still there. Although in this case you would have worked around the issue by not using clock anymore, other applications would still be broke.
I'm sorry to hear that, I hope you change your mind. PS: I don't want to mock you again, but I do still intend to review the code. |
There was a problem hiding this comment.
This looks ok to me. I have not done any runtime tests, so if someone can do that I think it's good to go.
Build can be downloaded here:
https://github.com/KrahJohlito/Open-PS2-Loader/suites/885397230/artifacts/10457707
|
@KrahJohlito, @rickgaiser, thank you very much for the work, I and @J013k we tested this test build 1519, But we have a doubt, if the fix of "clock() function" is moved recently to the PS2DK, Also, it is not needed update our PS2SDK for compile the OPL? Best regards. EDIT: Well it is answered in psx-place that yes that this 1519 build have the fix from PS2SDK. |
|
@rickgaiser i have a doubt, why you suggest squash and merge this PR, instead the standard merge? There it is a lot of commits, 11, wouldn't it be better to merge them all separately so that each one of them can be well Best regards. |
|
Within this 1 PR the same lines are changed multiple times. The separate commits are not usable/finished, but the end result is. That's why I suggested the squash, so these multiple changes are squashed into 1. So in this case I think it's cleaner to squash them into 1, but on the other hand you do loose some interesting commit information. I'm not sure in this case what's best, I have doubts as well. Do whatever you think is best ;). |
|
@rickgaiser, mmm... well, i'm going to bet on how we did so far, use the standard merge so that they Best regards. |
Pull Request checklist
Note: these are not necessarily requirements
Pull Request description
Take two on this.. same as before but this time I've also switched all use of clock() to ps2_clock() since it works without issues, and fixed the Last Played Auto Start counter now also.
Deferred calls are already in use in current builds so I see no issue this going ahead due to them, they could possibly be looked at later when more time is available.
As for the loading icon.. we could only display it after gInitComplete to avoid showing the default icon and the custom theme icon switch.. but some people may not like this as it means you don't see any icon until all device etc are loaded.. so I have just left it for now.