-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clang-format related changes #240
Conversation
I can't merge this pull request, appears the message of: Best regards. |
Don't merge it yet. I'd like to wait for a few more comments and for libc
changes to get merged.
On Mon, Jan 27, 2020 at 2:18 PM ElPatas1 ***@***.***> wrote:
I can't merge this pull request, appears the message of:
"This branch has conflicts that must be resolved."
Best regards.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#240>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAM4OHTGCLZ27FKELOEFS6LQ746RFANCNFSM4KLO6DYQ>
.
--
--
~Julian Uy
|
I see, thank you. Best regards. |
I like the new "format" target you added, is makes it easy for everyone to use clang-format. But why has the coding standard changed? I can understand fine-tuning the previous coding standard, or re-running the standard on all files, but this change is larger than it needs to be.
Changing this many lines of code also has a negative effect on for instance git blame or git cherry-pick. Tools I use regulary to track bugs/changes and cherry-pick commits from different branches. |
80e8f5e
to
d2e516a
Compare
I dropped the configuration changes and rebased. |
602f14b
to
ee1a828
Compare
Probably #287 should be merged before this. I can rebase easily |
The results of this PR look great. If you can rebase after #287 is merged I'll pull this PR. |
There will be a conflict when #287 is merged, so merge that first, I rebase this branch, then it is possible to merge this one. |
Hi, the PR of #287 has been merged. Best regards. |
ee1a828
to
a4dcfc5
Compare
Clang-format related changes
Pull Request checklist
Note: these are not necessarily requirements
Pull Request description
Added sections to not run clang-format on.
Added a new Makefile rule to run clang-format.
Adds formatting check to continuous integration.
Run clang-format on files.