Skip to content

Conversation

@leptun
Copy link
Collaborator

@leptun leptun commented Aug 18, 2020

Altfan detection is overriden by default after updating firmware.

@DRracer DRracer added the FW 3.9.1 bugfixes and tiny features label Aug 18, 2020
@DRracer
Copy link
Collaborator

DRracer commented Aug 18, 2020

Addressing the broad discussion in PR #2784 - what you see here is the latest generally accepted solution reflecting also the community remarks (@josefprusa @gregsaun @vertigo235 FYI).

The technical idea is as follows:
We inhibit alternative fan detection only when the EEPROM is erased.

  • That means our freshly manufactured machines will try to detect an alternative fan and record it into EEPROM upon start.
  • Upgrading from a previous firmware will NOT activate/override fan speed autodetection - it will keep whatever has been set in the EEPROM (i.e. 100% or 50% PWM).

This shall solve the vast majority of firmware upgrades even on modded printers (i.e. will keep their fan speed at 100%).

  • The only problem will arise in case of an erased EEPROM. In such a case the user of a printer with a different fan shall take extra steps to set the fan speed back to 100% if he wishes.
  • Please note we haven't found a reliable way of detecting a freshly manufactured Original Prusa i3 MK3S printer to inhibit the altfan detection only in such a case.

Generally (addressing the hot discussions in PR #2784 and PR #2692) :

  1. The firmware 3.9.1 is not finished/released yet, we are looking for a quality solution of the whole fan issue.
  2. If a PR gets merged into master, it means the (part of) solution was accepted in-house and was ready to be tested on printers internally. It may be subject to change after integration tests which are now running.
  3. We are an open source company and we do listen to the community.
    We even listen to people running heavily modified HW.
    If we weren't, this PR or any other discussion will not take place, right?
    So please keep the discussion at a technical level. Offensive comments will not help anyone.
  4. We are still considering a better PWM control for fans (quieter, safer with much more robust speed readings) for next FW updates.

3d-gussner and others added 2 commits August 20, 2020 15:14
EEPROM_ALTFAN_OVERRIDE and EEPROM_EXPERIMENTAL_VISIBILITY are compared to 0xFF in the code that's why I keep the uint8.
Update ALTFAN eeprom documentation
@DRracer DRracer merged commit 7728446 into prusa3d:MK3 Aug 20, 2020
@vertigo235
Copy link

Nice work Prusa team, and thank you for listening to feedback from us early bleeding edge testers.

@leptun leptun deleted the PFW-1134-ALTFAN_KILLSWITCH branch January 31, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FW 3.9.1 bugfixes and tiny features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants