Skip to content

Conversation

@leptun
Copy link
Collaborator

@leptun leptun commented Jul 29, 2020

Related to #2692
PFW-1134

@3d-gussner
Copy link
Collaborator

Resources previous pulled PR vs this PR:

Printer FW390 program space FW390 mem PR program space PR mem Diff program Diff mem
MK3S 245948 6441 246266 6442 +318 +1
MK3 247148 6471 247316 6471 +168 +0
MK25S 13a 219568 6264 219736 6264 +168 +0
MK25S 10a 218910 6266 219088 6266 +178 +0
MK25 13a 223482 6314 223644 6314 +0 +0
MK25 10a 222944 6314 223006 6314 +0 +0

Copy link
Collaborator

@DRracer DRracer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address my comments in the code

@DRracer DRracer added the FW 3.9.1 bugfixes and tiny features label Aug 4, 2020
@DRracer DRracer merged commit 22a8c18 into prusa3d:MK3 Aug 6, 2020
Copy link
Collaborator

@3d-gussner 3d-gussner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stupid me forgot to submit comments

@vertigo235
Copy link

How do you enable the experimental menu? where is it located

@leptun
Copy link
Collaborator Author

leptun commented Aug 7, 2020

@vertigo235 The experimental menu can be enabled by going into the "HW Setup" menu. While in the menu you have to long-press in order to toggle the Experimental menu visibility. The menu will appear at the end of the Support menu. The visibility and the ALTFAN override are persistent and can only be changed easily via the menu. If you really want to do the changes via gcode, you can use the EEPROM read/write Dcode.

@vertigo235
Copy link

I see, yes, that's what I deduced but there is no indication in the hw menu that it was enabled.

Tried it a few times and it is there now. Perhaps the longpress should be in the support menu not in the hw menu?

@vertigo235
Copy link

or maybe the experimental menu should be part of HW Setup

@wavexx
Copy link
Collaborator

wavexx commented Aug 7, 2020

Can we have a self-destruct option in the Experimental menu?
Every machine needs to have this option ;)

@vertigo235
Copy link

Gotta have a 'DO NOT USE' toggle in there for sure.

@vertigo235
Copy link

vertigo235 commented Aug 7, 2020

I think that up, up, down, down, left, right, left, right, B, A , Start would have been most appropriate to enable the powerup menu

@wavexx
Copy link
Collaborator

wavexx commented Aug 7, 2020

I kid I kid.. but daamn, these would be 5 star easter eggs :)

@gregsaun
Copy link

gregsaun commented Aug 8, 2020

Is the reduction speed activated after we flash the firmware on our current Prusa printers?

@leptun
Copy link
Collaborator Author

leptun commented Aug 8, 2020

Yes. You have to manually disable the altfan detection from the menu in order to have it at 100% speed

@gregsaun
Copy link

gregsaun commented Aug 8, 2020

So despite the concerns we have reported and other alternatives we have proposed to you, Prusa has decided to deliberately destroy some hotend fans used by the community. Wonderful...

@ogland
Copy link

ogland commented Aug 8, 2020

This is outrageous and evil, since you at Prusa are aware of what it will do and still chose this. The message you are sending again and again is extremely hostile towards modifications.

@Panayiotis-git
Copy link
Contributor

Just an idea: What if, when the altfan is detected, a message is shown to the user informing about the speed change and where to navigate to revert the change? Perhaps a choice to directly go to that page?

(Sorry, I cannot view the sources so I cannot check if this is even doable with the current implementation.)

@CacikeOtoao
Copy link

This has to be a joke, there is no way that you would implement a piece of code that will instantly damage a third party piece of equipment that was installed properly. If indeed that is the way this works you might be exposing yourself to possible consumer law infractions in some places. You HAVE to make sure there is a warning in the LCD for the people that won’t be aware of this upon flashing.

@3d-gussner
Copy link
Collaborator

I know people will hate me for this, but here my 2ct:

  • Prusa provides a firmware that is tailored around their printers to perform in their specs. So if they decide that their chosen ALTFAN at 50% speed is sufficient to cool the hotend and quiet enough than it is up to them to tailor their firmware.

  • Everyone that modifies the hardware/electronics/design should be prepared to also to modify the firmware.

    • I have only one Prusa MK3s left "stock" all others are modded and some need modified firmware.
    • I can't expect from any company to suite all wishes and if I change something I have to deal with it.
  • Some may argue that they changed the Noctua fan as it performs (in their opinion / including me in some cases) poorly and now flashing the "stock" firmware they run only at 50%. I changed my hotend fan at some Prusa printers and so I have to do make sure they operate like I expect them to:

    • I can comment out #define EXTRUDER_ALTFAN_DETECT in the variation file.
    • I can change #define EXTRUDER_ALTFAN_SPEED_SILENT 128 to 255 to have full speed again.
    • I can use this "hidden" menu to change the behavior.
  • I am OUT OF SPECS with my machine mods, so I have to do something about it.

So despite the concerns we have reported and other alternatives we have proposed to you, Prusa has decided to deliberately destroy some hotend fans used by the community. Wonderful...

@gregsaun The user has chosen to got OUT OF SPECS with their mod. Prusa added an option, maybe not the best but at least they listened to the community and added it to their "stock" firmware. And why should this change destroy fans?

This is outrageous and evil, since you at Prusa are aware of what it will do and still chose this. The message you are sending again and again is extremely hostile towards modifications.

@ogland What is outrageous or evil about that Prusa adds an option the switch the behavior of an ALTFAN without need to compile you own custom firmware.

This has to be a joke, there is no way that you would implement a piece of code that will instantly damage a third party piece of equipment that was installed properly. If indeed that is the way this works you might be exposing yourself to possible consumer law infractions in some places. You HAVE to make sure there is a warning in the LCD for the people that won’t be aware of this upon flashing.

@CacikeOtoao

  1. The code doesn't instantly damage instantly anything! Their choice of ALTFAN at 50% has been tested and approved to operate as well as the previous one.
  2. Glad that I am not living in a place that this kind of things have a chance to get to court. You modify a printer fan so you are out of specs using a not correct/tailored to NEW specs firmware.

Things could be handled differently BUT these kind of comments aren't helping at all.

Please make constructive comments and provide ideas like Panayiotis-git did.
Don't expect Prusa to solve your selfmade issues.

If you need custom firmware checkout vertigo235/zaribo/my github and other places.

@3d-gussner
Copy link
Collaborator

I am big fan of Mods BUT these need sometimes custom firmware:

  • Love the Bear but needs a modified firmware as the MK3 Extruder R4++ design is different than what Bear/Zaribo/Bondtech using (based on R3 diamensions)
  • Bondtech users need a custom firmware as the dimensions are different.
  • Love the faster Sunon and LDO part cooling fans as they are way better performing BUT they are defiantly louder. I am OK with louder but Prusa MK3s users expect a "silent" printer.
  • Love the work and effort vertigo235 and others do to make MODs accessible to a wide range of people that aren't that comfortable to compile their firmware.

Love this community and it make me really SAD and disappointed when these kind of flares and negative non-constructive messages pop-up.

@gregsaun
Copy link

gregsaun commented Aug 8, 2020

@gregsaun The user has chosen to got OUT OF SPECS with their mod. Prusa added an option, maybe not the best but at least they listened to the community and added it to their "stock" firmware. And why should this change destroy fans?

I 100% agree with the out of specs, no problem with this. However, there are simple solution to avoid this that took much less time to implement than all those talks have generated...

@CacikeOtoao
Copy link

@3d-gussner so for clarification purposes. If I have a MK3S with a Sunon fan and I flash 3.9.1 with the current implementation been cited here, the Sunon will not suffer any damage. It will only spin at 4,000RPM until I enable the AltFan function from the secret menu?

@wavexx
Copy link
Collaborator

wavexx commented Aug 8, 2020

@3d-gussner I'll add my (serious) view of this: you don't need to go "out of spec" to run into this issue.

  • Noctua breaks down, order a replacement
  • Slap on the first compatible 40mm fan you have while waiting to avoid downtime

This is IMHO 100% legitimate and done with the best intentions (matching power/cfm requirements).
I know I did it on other printers a number of times.

@gregsaun
Copy link

gregsaun commented Aug 8, 2020

@josefprusa you said outside github: it autodetects is for users who have it installed while updating and you will be able to switch this on/off in the menu. -> Do you mean the that when we flash the firmware it autodetects we are using a Sunon and ask you if you want to disable it?

I am sorry but I understand this differently than the answer from @leptun I had here: #2784 (comment). To me this means that current users will have to manual change this setting in a hidden menu otherwise it will BY DEFAULT damage the fan.

If you warn the current user and give him the choice to NOT deliberately damage the fan then I don't see the problem.

Could we have a precision on how this works then?

@vertigo235
Copy link

@gregsaun That's not how it worked when I flashed it, the FW certainly does detect it and changes your fan speed, but there is no warning or notification to the user as far as I could tell.

You would have to know to activate the secret menu, and then how, enable to power your machine up again.

It's really easy to not know this even if you are an experienced user, I had built the FW at least 3 times and never noticed the slower fan speed until another community member told me about it.

@gregsaun
Copy link

gregsaun commented Aug 8, 2020

@vertigo235 So why @josefprusa is angry at me then?

I have to warn my community that they might damaged permanently their fan on the next firmware upgrade. I should have kept this silent and let my customers damage their fan because they didn't see this little hidden menu and the reduction of speed?

@3d-gussner
Copy link
Collaborator

Easier can be seen differently by people.

Prusa has their point to not make this standard 100% fan speed as it fulfilled their specs for the fan of choice at 50%. Also make it non visible to the majority of their users is a good point.

Modders would like to have it done differently and everything customizable as possible.

So what is the correct way to do this? There is no ONE way to satisfy everyone.

Where I am very disappointed in is the reaction of the some people of community ranting about a compromise Prusa tried to fit both needs.

Standard user want to use realible hardware and software and not be overwhelmed by the choices they have to make.

Modders should be glad that they can deactivate the slow 50% fan to 100% in stock firmware even it is bit tricky to do that. And it has to be done ONCE.

I personally was surprised that Prusa considered this option and spent developing time on something that is out of their specs.

I live in a country where people first complain and think later.

The 3D printing community is better than this.

@gregsaun
Copy link

gregsaun commented Aug 8, 2020

Yes so what is the problem if I inform my community that they MIGHT DAMAGE THE FAN?

@vertigo235
Copy link

FWIW I'm OK with the solution, but all the builds that I make will have ALTFAN set to 255 as god intended, so the ALTFAN killswitch will effectively do nothing anyhow.

@vertigo235
Copy link

@gregsaun As long as you communicate that they may damage the fan unless they disable the ALTFAN detection, then I can't see how there is any problem with that. The ability to disable the "feature" in the stock FW has been addressed.

Thank you Prusa team for listening to the community.

@gregsaun
Copy link

gregsaun commented Aug 8, 2020

@vertigo235 I did obviously provide an explanation on how to activate the hidden menu to not damage the fan. I think it is important to also warn the customers before the firmware is available to be sure everyone gets the info in time.

@vertigo235
Copy link

As it is an unreleased feature, things can change based on feedback (as it already has), so we should give the Prusa team time to take take the feedback and perhaps adjust before the final release.

To that note, maybe it was premature to sound a general alarm since the feature set is not complete yet for the next release, at least I think?

@3d-gussner
Copy link
Collaborator

@gregsaun maybe you should advise your users to use the @vertigo235 Bear firmware as it is well maintained and very fast updated.
I will also add the 100% altfan to the Zaribo firmware as most printers will have sunon hotend Fans.

@gregsaun
Copy link

gregsaun commented Aug 8, 2020

@vertigo235 I agree but we have discuss this since several weeks now, we have a merge here, a confirmation from the developer how it will work and how it will be done in the menu... I think it was the moment to inform my community on how the firmware evolve. I personally know that they don't read release notes so I did prefer to be safer than sorry.

@gregsaun
Copy link

gregsaun commented Aug 8, 2020

@gregsaun maybe you should advise your users to use the @vertigo235 Bear firmware as it is well maintained and very fast updated.
I will also add the 100% altfan to the Zaribo firmware as most printers will have sunon hotend Fans.

That was obviously part of my post, explaining the future of the Bear calibration firmware and that we are going to change how things are made. I was waiting on the developer program to make this smoother for the community but this is not available today.

@josefprusa
Copy link
Contributor

@gregsaun Autodetection is what we agreed on with @DRracer who is the FW team leader at the time when we were first planning how to implement it and that is how it is going to be. I am sorry that external devs don’t know everything, next time confront @DRracer. Stop your witch hunt until the beta of the FW is out.

@gregsaun
Copy link

gregsaun commented Aug 8, 2020

@josefprusa then it is on your side Jo, I've asked here before positing to be sure it was the correct behavior. I have just taken the decision to be safer than sorry regarding my customers.

@vertigo235
Copy link

I'm a little confused now , does that mean this feature is incomplete? Is it not behaving as intended?

@gregsaun
Copy link

gregsaun commented Aug 8, 2020

@DRracer sorry you are in this position, I really appreciate all your quality work and I am deeply convinced that Prusa is very lucky to have you.

@vertigo235
Copy link

If your external developers don't know what is going on then you certainly can't expect the general community to know either.

@vertigo235
Copy link

Was it a mistake in assuming this is the proper forum for customers to provide feedback and testing results from merged code in the Prusa FW?

If we do this we are accused of being witch hunters?

@gregsaun
Copy link

gregsaun commented Aug 8, 2020

If a customer has a hotend fan running at 5000RPM, will it go down to 2500RPM?

@gregsaun
Copy link

gregsaun commented Aug 8, 2020

If we reset the firmware, in what mode we will be then?

@vertigo235
Copy link

Nobody resets their firmware after updating so resetting EEPROM upon upgrading is a poor assumption that your users will do that.

Is that part of the recommendation as you update the FW? I could be out of process.

@vertigo235
Copy link

I would not think that I would be expected to re calibrate all my sheets etc after updating my FW

@gregsaun
Copy link

gregsaun commented Aug 8, 2020

@vertigo235 no but you might have a customer resetting the firmware after seeing a weird behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FW 3.9.1 bugfixes and tiny features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants