Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement support for editing features #43

Closed
proycon opened this issue Aug 22, 2016 · 4 comments
Closed

Implement support for editing features #43

proycon opened this issue Aug 22, 2016 · 4 comments
Assignees
@proycon
Labels
enhancement ready
Milestone
v0.7

Comments

@proycon
Copy link
Owner

proycon commented Aug 22, 2016

No description provided.

@proycon proycon self-assigned this Aug 22, 2016
@proycon proycon added this to the v0.7 milestone Oct 13, 2016
proycon added a commit that referenced this issue Oct 26, 2016
@proycon
Refactored folia_label calls, function now takes set label into accou…
41ff49f 
…nt directly (refactors #37) + Render features in viewer (start of #43)
proycon added a commit that referenced this issue Oct 26, 2016
@proycon
Use labels from set definition for feature subsets and classes (#43)
b2b450f
proycon added a commit that referenced this issue Oct 26, 2016
@proycon
adding feature edit fields to interface (#43), choice menus from set …
2ac1941 
…definitions still to be implemented
proycon added a commit that referenced this issue Oct 26, 2016
@proycon
Added renderfeaturefields() to render edit fields (subset, class) for…
8a0928b 
… editing features (issue #43) with full support for set definitions (choice lists)
proycon added a commit that referenced this issue Oct 26, 2016
@proycon
Working on feature submission (#43, not done yet) + refactored some o…
23ce787 
…f the higher order processing into build_parentselector_query()
proycon added a commit that referenced this issue Oct 27, 2016
@proycon
formulate feature editing queries (issue #43)
376901c
proycon added a commit that referenced this issue Oct 27, 2016
@proycon
automatically populate subset classes list when a different subset is…
4672878 
… selected (#43)
@proycon proycon added the ready label Oct 27, 2016
@proycon
Copy link
Owner Author

proycon commented Oct 27, 2016

Implemented, but will probably break under correction mode currently

@proycon
Copy link
Owner Author

proycon commented Nov 8, 2016

Feature sets that are predefined and usable as an attribute shortcut don't seem to be propagated from foliadocserve now.

@proycon
Copy link
Owner Author

proycon commented Nov 8, 2016 •
edited
Loading

Works again, but still a (regression?) problem upon editing a feature:

USE proycon/example EDIT feat WHERE subset = "strength" AND class = "heavy"  WITH class "heavy"  FOR ID "WR-P-E-J-0000000001.text.sentiment.1" FORMAT flat RETURN ancestor-focus

  File "/home/proycon/lamachine/lib/python3.5/site-packages/foliadocserve-0.5-py3.5.egg/foliadocserve/foliadocserve.py", line 575, in query
    result =  query(doc,False,self.debug >= 2)
  File "/home/proycon/lamachine/lib/python3.5/site-packages/PyNLPl-1.1.0-py3.5.egg/pynlpl/formats/fql.py", line 1889, in __call__
    focusselection, targetselection = self.action(self, targetselector, debug) #selecting focus elements further constrains the target selection (if any), return values will be lists
  File "/home/proycon/lamachine/lib/python3.5/site-packages/PyNLPl-1.1.0-py3.5.egg/pynlpl/formats/fql.py", line 1665, in __call__
    focusselection.append( target.add(action.focus.Class, **action.assignments) ) #handles span annotation too
  File "/home/proycon/lamachine/lib/python3.5/site-packages/PyNLPl-1.1.0-py3.5.egg/pynlpl/formats/folia.py", line 4088, in add
    return self.append(child, *args, **kwargs)
  File "/home/proycon/lamachine/lib/python3.5/site-packages/PyNLPl-1.1.0-py3.5.egg/pynlpl/formats/folia.py", line 4075, in append
    return super(AbstractSpanAnnotation,self).append(child, *args, **kwargs)
  File "/home/proycon/lamachine/lib/python3.5/site-packages/PyNLPl-1.1.0-py3.5.egg/pynlpl/formats/folia.py", line 1413, in append
    child = Class(self.doc, *args, **kwargs)
  File "/home/proycon/lamachine/lib/python3.5/site-packages/PyNLPl-1.1.0-py3.5.egg/pynlpl/formats/folia.py", line 4003, in __init__
    raise Exception("No subset specified for " + self.__class__.__name__)
[QUERY FAILED] FoLiA Error in proycon/example: [Exception] No subset specified for Feature

proycon added a commit that referenced this issue Nov 17, 2016
@proycon
fix in submission of features (#43)
e243165
@proycon
Copy link
Owner Author

proycon commented Nov 17, 2016

fixed

@proycon proycon mentioned this issue Dec 13, 2016
Closed
@proycon proycon closed this as completed Dec 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@proycon proycon

Labels
enhancement ready
Projects
None yet
Milestone
v0.7
Development

No branches or pull requests
1 participant
@proycon