Do not reverse bytes for NullVM.#282
Merged
PiotrSikora merged 6 commits intoproxy-wasm:masterfrom Oct 2, 2022
Merged
Conversation
Contributor
Author
|
@PiotrSikora @mathetake can you please review? This is a follow-up change for #198. Thanks. |
knm3000
added a commit
to knm3000/envoy-1
that referenced
this pull request
Jun 21, 2022
Fixes WASM on s390x https://issues.redhat.com/browse/MAISTRA-2648 The permanent fixes are: proxy-wasm/proxy-wasm-cpp-host#198 proxy-wasm/proxy-wasm-cpp-host#282 Signed-off-by: Konstantin Maksimov konstantin.maksimov@ibm.com
knm3000
added a commit
to knm3000/proxy-wasm-cpp-host-1
that referenced
this pull request
Jun 23, 2022
Fixes WASM on s390x https://issues.redhat.com/browse/MAISTRA-2648 The permanent fixes are: proxy-wasm/proxy-wasm-cpp-host#198 proxy-wasm/proxy-wasm-cpp-host#282
knm3000
added a commit
to knm3000/proxy-wasm-cpp-host-1
that referenced
this pull request
Jun 24, 2022
Fixes WASM on s390x https://issues.redhat.com/browse/MAISTRA-2648 Corresponding proxy-wasm/proxy-wasm-cpp-host PRs: proxy-wasm/proxy-wasm-cpp-host#198 proxy-wasm/proxy-wasm-cpp-host#282
knm3000
added a commit
to knm3000/proxy-wasm-cpp-host-1
that referenced
this pull request
Jun 24, 2022
Fixes WASM on s390x https://issues.redhat.com/browse/MAISTRA-2648 Corresponding proxy-wasm/proxy-wasm-cpp-host PRs: proxy-wasm/proxy-wasm-cpp-host#198 proxy-wasm/proxy-wasm-cpp-host#282
Contributor
Author
|
@PiotrSikora @mathetake would you please review this? Initial big-endian changes have already been merged in #198, but now I'd like to fix null-vm use case. Thanks. |
mathetake
reviewed
Jul 25, 2022
Contributor
|
could you elaborate on what's the error in the test, and how does this solve it? |
Contributor
Author
|
@mathetake thanks for the review. I've opened an issue and added the error details #294. Can you please take a look? |
Member
Could you add a test that fails without this change? We cannot rely on tests 3 repositories downstream. |
PiotrSikora
reviewed
Jul 29, 2022
oschaaf
pushed a commit
to oschaaf/proxy-wasm-cpp-host
that referenced
this pull request
Aug 4, 2022
Fixes WASM on s390x https://issues.redhat.com/browse/MAISTRA-2648 Corresponding proxy-wasm/proxy-wasm-cpp-host PRs: proxy-wasm#198 proxy-wasm#282
Fixes proxy-wasm#294 Signed-off-by: Konstantin Maksimov <konstantin.maksimov@ibm.com>
Contributor
Author
|
@PiotrSikora thanks for the review, I've made the proposed changes, can you please take a look? |
additional changes: - moved the call to isWasmByteOrder() into htowasm/wasmtoh macros - added surrounding brackets to htowasm/wasmtoh - removed debug leftover Fixes proxy-wasm#294 Signed-off-by: Konstantin Maksimov <konstantin.maksimov@ibm.com>
knm3000
force-pushed
the
nullvm-s390x
branch
from
a32a30c to
6e273eb
Compare
Contributor
Author
|
@PiotrSikora I've made the requested changes:
|
mpwarres
requested changes
Sep 13, 2022
more changes: - renamed is_wasm_byte_order to vm_uses_wasm_byte_order - renamed isWasmByteOrder() to usesWasmByteOrder() Fixes proxy-wasm#294 Signed-off-by: Konstantin Maksimov <konstantin.maksimov@ibm.com>
Contributor
Author
|
@mpwarres thanks for the review, please see my comments. |
mpwarres
approved these changes
Sep 14, 2022
Contributor
|
@PiotrSikora and/or @mathetake , I've finished my pass--this now awaits your approval. |
knm3000
added a commit
to knm3000/envoy-1
that referenced
this pull request
Sep 22, 2022
Fixes https://issues.redhat.com/browse/OSSM-1815 error in maistra-2.3 proxy-wasm fix: proxy-wasm/proxy-wasm-cpp-host#282 maistra-2.3 issue: https://issues.redhat.com/browse/OSSM-1956 Signed-off-by: Konstantin Maksimov <konstantin.maksimov@ibm.com>
PiotrSikora
reviewed
Sep 27, 2022
- use buf and buf_len variables for readability - added back word.h include - hardcoded usesWasmByteOrder() to true Fixes proxy-wasm#294 Signed-off-by: Konstantin Maksimov <konstantin.maksimov@ibm.com>
Contributor
Author
|
@PiotrSikora I've made the changes, can you please take a look? |
PiotrSikora
reviewed
Sep 30, 2022
- moved pairs test into a new file test/pairs_util_test.cc - run pairs test on all platforms - made contextOrEffectiveContext() null check a bit more readable Fixes proxy-wasm#294 Signed-off-by: Konstantin Maksimov <konstantin.maksimov@ibm.com>
knm3000
force-pushed
the
nullvm-s390x
branch
from
65c8c8f to
d0a3249
Compare
maistra-bot
pushed a commit
to maistra/envoy
that referenced
this pull request
Sep 30, 2022
Fixes https://issues.redhat.com/browse/OSSM-1815 error in maistra-2.3 proxy-wasm fix: proxy-wasm/proxy-wasm-cpp-host#282 maistra-2.3 issue: https://issues.redhat.com/browse/OSSM-1956 Signed-off-by: Konstantin Maksimov <konstantin.maksimov@ibm.com> Signed-off-by: Konstantin Maksimov <konstantin.maksimov@ibm.com>
PiotrSikora
approved these changes
Oct 1, 2022
Member
PiotrSikora
left a comment
PiotrSikora
left a comment
There was a problem hiding this comment.
LGTM, thanks! Please remove that unnecessary #include and this should be good to go.
more changes: - removed unnecessary #include from test/null_vm_test.cc Fixes proxy-wasm#294 Signed-off-by: Konstantin Maksimov <konstantin.maksimov@ibm.com>
PiotrSikora
changed the title
Member
|
Thanks! |
knm3000
added a commit
to knm3000/envoy-1
that referenced
this pull request
Feb 21, 2023
Upstream PR proxy-wasm/proxy-wasm-cpp-host#282 has been merged and maistra-2.4 branch includes these changes Signed-off-by: Konstantin Maksimov <konstantin.maksimov@ibm.com>
twghu
pushed a commit
to twghu/maistra-envoy
that referenced
this pull request
Feb 28, 2023
Upstream PR proxy-wasm/proxy-wasm-cpp-host#282 has been merged and maistra-2.4 branch includes these changes Signed-off-by: Konstantin Maksimov <konstantin.maksimov@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the following istio proxy test on s390x:
https://github.com/istio/proxy/blob/master/test/envoye2e/tcp_metadata_exchange/tcp_metadata_exchange_test.go
Resolves #294