OSSM-1856: Use upstream proxy-wasm-cpp-host#195
Merged
maistra-bot merged 2 commits intomaistra:maistra-2.3from Aug 25, 2022
Merged
OSSM-1856: Use upstream proxy-wasm-cpp-host#195maistra-bot merged 2 commits intomaistra:maistra-2.3from
maistra-bot merged 2 commits intomaistra:maistra-2.3from
Conversation
Upstream has support for using a local SSL library, which was added in this PR: proxy-wasm/proxy-wasm-cpp-host#219 The change above incorporates our downstream changes so there's no need to use our fork for the OpenSSL purpose.
* wasm: update Proxy-Wasm C++ Host to latest. * Fixes #20007 Signed-off-by: Piotr Sikora piotrsikora@google.com This commit cherry picks commit 2a9565d which was somehow mixed with our downstream changes, and some changes were lost. Propably this happened to fix compiler failures due to the proxy-wasm-cpp-host dependency not being updated in our tree.
Contributor
|
The change from the Maistra proxy-wasm-cpp-host 9b122e75d40b10982862fab1bcdb2eb4dbf57d8a seems catered for by proxy-wasm/proxy-wasm-cpp-host#219 As this is the only code change to the earlier Maistra Version is an ideal change. As long as we can support the need to build test with OpenSSL as per 8849b2cc7523034c73fb2e27334c25f9c640a0e3. The only other important change is 3372cb3a982a02a8378b67a1df99078f5d8d581e which at the time of comment was still an open PR 282 |
twghu
approved these changes
Aug 16, 2022
tedjpoole
approved these changes
Aug 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.