Skip to content
This repository was archived by the owner on Aug 29, 2023. It is now read-only.

fix example for OS-specific additional setup steps #202

Merged
marten-seemann merged 1 commit into from
Oct 12, 2021
Merged

fix example for OS-specific additional setup steps #202

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,11 @@ runs:
run: echo "do some initial setup"
- name: Step 2
shell: bash
run: echo "do some Linux-specific setup"
if: ${{ matrix.os == 'ubuntu' }}
run: |
# note that it's not possible to use if: on the step, see https://github.com/actions/runner/issues/834
if [[ "${{ matrix.os }}" == "ubuntu" ]]; then
Copy link
Contributor

@mvdan mvdan Oct 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not keep the check as if:, then do the echo in run:?

Copy link
Contributor Author

@marten-seemann marten-seemann Oct 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because for some reason, GitHub Actions doesn't process ifs in included workflows.
We should probably open an issue in the support forum.

Copy link
Contributor

@mvdan mvdan Oct 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! If you do that, I'll be sure to follow and upvote :) At least we should include a TODO or comment here that explains the weirdness.

Copy link
Contributor

@aschmahmann aschmahmann Oct 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actions/runner#834

echo "do some Linux-specific setup"
fi
```

These setup steps are run after the repository has been checked out and after Go has been installed, but before any tests or checks are run.
Expand Down