This repository was archived by the owner on Aug 29, 2023. It is now read-only.
fix example for OS-specific additional setup steps #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdan
reviewed
Oct 12, 2021
| run: echo "do some Linux-specific setup" | ||
| if: ${{ matrix.os == 'ubuntu' }} | ||
| run: | | ||
| if [[ "${{ matrix.os }}" == "ubuntu" ]]; then |
Contributor
There was a problem hiding this comment.
why not keep the check as if:, then do the echo in run:?
Contributor
Author
There was a problem hiding this comment.
Because for some reason, GitHub Actions doesn't process ifs in included workflows.
We should probably open an issue in the support forum.
Contributor
There was a problem hiding this comment.
Ah! If you do that, I'll be sure to follow and upvote :) At least we should include a TODO or comment here that explains the weirdness.
aschmahmann
approved these changes
Oct 12, 2021
marten-seemann
force-pushed
the
fix-additional-steps-os
branch
from
f6464e9 to
ed4f92d
Compare
marten-seemann
force-pushed
the
fix-additional-steps-os
branch
from
ed4f92d to
825e356
Compare
Contributor
Author
|
It looks like GitHub (finally!) fixed this issue: actions/runner#834 (comment). |
marten-seemann
added a commit
that referenced
this pull request
Nov 12, 2021
GitHub Actions finally fixed the issue, see actions/runner#834 (comment). This reverts #202.
marten-seemann
added a commit
that referenced
this pull request
Nov 12, 2021
GitHub Actions finally fixed the issue, see actions/runner#834 (comment). This reverts #202.
galargh
pushed a commit
that referenced
this pull request
Dec 8, 2021
GitHub Actions finally fixed the issue, see actions/runner#834 (comment). This reverts #202.
galargh
pushed a commit
that referenced
this pull request
Dec 8, 2021
GitHub Actions finally fixed the issue, see actions/runner#834 (comment). This reverts #202.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.