Skip to content

Conversation

@bobrik
Copy link

@bobrik bobrik commented Mar 17, 2021

This unlocks setting source_ip_address for HTTP probes in blackbox_exporter.

@bobrik
Copy link
Author

bobrik commented Mar 17, 2021

prometheus/blackbox_exporter#765 is how it's supposed to be used.

Not sure what to do with go1.9 and go1.10 failures.

@roidelapluie
Copy link
Member

Can you rebase this ?

This unlocks setting `source_ip_address` for HTTP probes in `blackbox_exporter`.

Signed-off-by: Ivan Babrou <[email protected]>
@bobrik bobrik force-pushed the ivan/source-addr branch from 5df092a to b6099cd Compare March 17, 2021 16:23
@bobrik
Copy link
Author

bobrik commented Mar 17, 2021

Done, the conflict was in imports:

$ git diff config/http_config.go
diff --cc config/http_config.go
index 07de306,c0c4d5b..0000000
--- a/config/http_config.go
+++ b/config/http_config.go
@@@ -17,7 -17,8 +17,8 @@@ package confi

  import (
        "bytes"
+       "context"
 -      "crypto/md5"
 +      "crypto/sha256"
        "crypto/tls"
        "crypto/x509"
        "fmt"

@roidelapluie
Copy link
Member

I think that it is not necessary to change common, that we could do everything in blackbox exporter.

@bobrik
Copy link
Author

bobrik commented Mar 17, 2021

Here's what I came up with without changing prometheus/common: prometheus/blackbox_exporter#766. It leaks some details about use of tracing and how dialer is set up otherwise in prometheus/common.

@SuperQ
Copy link
Member

SuperQ commented Feb 25, 2023

This needs a rebase.

@bobrik bobrik closed this Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants