Skip to content

Conversation

@bobrik
Copy link
Contributor

@bobrik bobrik commented Mar 17, 2021

This is a logical continuation of #262.

It's the same as #765 but without changing prometheus/common as @roidelapluie suggested.

Signed-off-by: Ivan Babrou [email protected]

This is a logical continuation of prometheus#262.

Signed-off-by: Ivan Babrou <[email protected]>
@bobrik
Copy link
Contributor Author

bobrik commented Mar 17, 2021

@roidelapluie, this approach doesn't seem to work very well, given that there may be multiple layers of transport.

@roidelapluie
Copy link
Member

@roidelapluie, this approach doesn't seem to work very well, given that there may be multiple layers of transport.

Can you be more explicit?

@bobrik
Copy link
Contributor Author

bobrik commented Mar 29, 2021

Look at the failed test:

panic: interface conversion: http.RoundTripper is *config.basicAuthRoundTripper, not *http.Transport

I don't see a good way to update DialContext in http.RoundTripper that is wrapped by config.basicAuthRoundTripper.

@roidelapluie
Copy link
Member

Hello @bobrik . Now the HTTP client supports passing special dialcontext funcs so we could implement all this in the blackbox exporter: prometheus/common#291

@bobrik bobrik closed this Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants