Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(*): add ilm metrics #513

Merged
merged 4 commits into from
Jan 21, 2023
Merged

feat(*): add ilm metrics #513

merged 4 commits into from
Jan 21, 2023

Conversation

iishabakaev
Copy link
Contributor

Add ilm cluster status and ilm index metrics from /_all/_ilm/explain

@arapaho
Copy link

arapaho commented Jan 3, 2022

Hi @iishabakaev! It seems some work has already been done in #457. Also, as your work seems very close to @mokrinsky's one, it could be a good idea to liaise with them to avoid duplicate work.

@Evesy
Copy link
Contributor

Evesy commented May 20, 2022

@arapaho The other PR seems abandoned and isn't getting any response from the original author so would be good to continue with this if @iishabakaev is happy to carry on -- If not I'm happy to pick it up

@iishabakaev iishabakaev force-pushed the feature/ilm branch 3 times, most recently from a5d9c6a to bb4b91c Compare June 8, 2022 21:19
@iishabakaev
Copy link
Contributor Author

Hi @arapaho! Seems like other PR wont be merged due in inactivity.
I will try done this feature.
Can you give me feedback?

@NikitaIvankov1992
Copy link

Hey :)

We're also interested in such a feature, can we ask when the PR will be reviewed/merged?
Metrics are very useful

Thanks in advance

@iishabakaev
feat(*): add ilm metrics
73d23aa 
Signed-off-by: iishabakaev <[email protected]>
@iishabakaev
Copy link
Contributor Author

Hi!
@SuperQ
@sysadmind

Can I ask you guys to review this PR, please?
I wiil be happy to have any feedback

For those who uses ILM in their clusters (as I do) its very helpful metrics

sysadmind
sysadmind requested changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@sysadmind sysadmind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good functionality wise. Just some refactoring before this is ready to merge.

Thanks! 😄

collector/ilm_status_test.go Outdated Show resolved Hide resolved
collector/ilm_status_response.go Outdated Show resolved Hide resolved
collector/ilm_status_response.go Outdated Show resolved Hide resolved
collector/ilm_status.go Outdated Show resolved Hide resolved
collector/ilm_status.go Outdated Show resolved Hide resolved
collector/ilm_indices_test.go Outdated Show resolved Hide resolved
collector/ilm_indices_response.go Outdated Show resolved Hide resolved
collector/ilm_indices_response.go Outdated Show resolved Hide resolved
collector/ilm_indices.go Outdated Show resolved Hide resolved
collector/ilm_indices.go Outdated Show resolved Hide resolved
@NikitaIvankov1992
Copy link

Hey :)

any chance the change will be released? thanks

@rlapond
Copy link

rlapond commented Jan 5, 2023

Hi,

I'm commenting to show interest in this PR, any chance the review can be finished soon?

@iishabakaev iishabakaev force-pushed the feature/ilm branch 2 times, most recently from 8cfda85 to 43daa7b Compare January 9, 2023 20:06
@iishabakaev
Refactor ilm collectors
5500ee6 
Signed-off-by: Шабакаев Илья Исмаилович <[email protected]>
Signed-off-by: Шабакаев Илья Исмаилович <[email protected]>
@iishabakaev
Copy link
Contributor Author

Hi! @sysadmind

Sorry for so long changes, but I finally did it
Can you, please, take a look again?

@iishabakaev iishabakaev requested a review from sysadmind January 16, 2023 07:05
sysadmind
sysadmind approved these changes Jan 21, 2023
View reviewed changes
Copy link
Contributor

@sysadmind sysadmind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fixes.

sysadmind
sysadmind reviewed Jan 21, 2023
View reviewed changes
Copy link
Contributor

@sysadmind sysadmind left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linter found a variable that needs to be fixed.

@iishabakaev
fix lint checks
96b4f36 
Signed-off-by: Шабакаев Илья Исмаилович <[email protected]>
@iishabakaev
Copy link
Contributor Author

Done.

@sysadmind sysadmind merged commit a5f6de3 into prometheus-community:master Jan 21, 2023
@m4sb5r m4sb5r mentioned this pull request Jan 30, 2023
Closed
@ClenchPaign
Copy link

Can you please update the README (https://github.com/prometheus-community/elasticsearch_exporter#readme) with the new metrics?

SuperQ added a commit that referenced this pull request Jun 29, 2023
@SuperQ
Merge pull request #735 from sysadmind/release-1.6.0
a5f4279 
BREAKING CHANGES:

The flag `--es.cluster_settings` has been renamed to `--collector.clustersettings`.

* [CHANGE] Rename --es.cluster_settings to --collector.clustersettings
* [FEATURE] Add ILM metrics #513
* [ENHANCEMENT] Add ElasticCloud node roles to role label #652
* [ENHANCEMENT] Add ability to use AWS IAM role for authentication #653
* [ENHANCEMENT] Add metric for index replica count #483
* [BUGFIX] Set elasticsearch_clusterinfo_version_info guage to 1 #728
* [BUGFIX] Fix index field counts with nested fields #675

---------

Signed-off-by: Joe Adams <[email protected]>
@multani multani mentioned this pull request May 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sysadmind sysadmind sysadmind approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@iishabakaev @arapaho @Evesy @NikitaIvankov1992 @rlapond @ClenchPaign @sysadmind