number_of_replicas #483
Merged
number_of_replicas #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandr Marchenko <[email protected]>
mac2000
force-pushed
the
number_of_replicas
branch
from
785a319 to
2a320bf
Compare
SuperQ
previously requested changes
Jan 19, 2022
|
sorry for a noob question but seems like I have stuck with this DCO whatever, is there a chance you can press the button or should I figure out how to fix this check? |
|
Any chance we can get this merged @SuperQ ? I would love to have this metric exported |
|
This needs a DCO sign-off. You can use |
Co-authored-by: Ben Kochie <[email protected]> Signed-off-by: Alexandr Marchenko <[email protected]>
mac2000
force-pushed
the
number_of_replicas
branch
from
7bcb364 to
ed48174
Compare
|
@SuperQ thank you, seems like it did the trick |
sysadmind
requested changes
Aug 8, 2022
Thanks indeed Co-authored-by: Joe Adams <[email protected]> Signed-off-by: Alexandr Marchenko <[email protected]>
mac2000
force-pushed
the
number_of_replicas
branch
from
f5fc035 to
9a69bc2
Compare
|
@SuperQ @sysadmind is there any chance it will be merged somewhere in the future or should something else be done? |
sysadmind
approved these changes
Nov 1, 2022
|
LGTM. Thanks! |
SuperQ
added a commit
that referenced
this pull request
Jun 29, 2023
BREAKING CHANGES: The flag `--es.cluster_settings` has been renamed to `--collector.clustersettings`. * [CHANGE] Rename --es.cluster_settings to --collector.clustersettings * [FEATURE] Add ILM metrics #513 * [ENHANCEMENT] Add ElasticCloud node roles to role label #652 * [ENHANCEMENT] Add ability to use AWS IAM role for authentication #653 * [ENHANCEMENT] Add metric for index replica count #483 * [BUGFIX] Set elasticsearch_clusterinfo_version_info guage to 1 #728 * [BUGFIX] Fix index field counts with nested fields #675 --------- Signed-off-by: Joe Adams <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: hunting for indices with
number_of_replicasbeing set to zero, which might cause data loss in certain scenarios, need this metric to configure alertoutput will be:
closes #482