Configure ArgoCD to use Replace=true to apply CRDs
#58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simu
force-pushed
the
fix/argocd-replace-crds
branch
2 times, most recently
from
f555306 to
f059b18
Compare
simu
force-pushed
the
fix/argocd-replace-crds
branch
from
f059b18 to
6a40dfc
Compare
|
I guess this is fine because we re-apply the CRDs anyway from ArgoCD? Might be fine argoproj/argo-cd#5704 (comment) |
bastjan
approved these changes
Oct 11, 2022
Reading through the linked issues, ArgoCD won't actually replace the CRD resources unless you choose "Force" for a manual sync, see argoproj/gitops-engine#252. We should probably migrate this to use server-side apply once we've upgraded to ArgoCD v2.5 (cf. argoproj/argo-cd#820 (comment)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.