Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ArgoCD sync policy ServerSideApply=true for CRDs #59

Closed
simu opened this issue Oct 12, 2022 · 1 comment
Closed

Use ArgoCD sync policy ServerSideApply=true for CRDs #59

simu opened this issue Oct 12, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@simu
Copy link
Member

simu commented Oct 12, 2022

Context

We've updated the component to use ArgoCD sync policy Replace=true for the CRDs in #58 to workaround #57. This unblocks us short-term. However, ArgoCD v2.5 will have support for server-side apply with sync policy ServerSideApply=true and we should switch to that to ensure that CRDs are never deleted and recreated during sync (this shouldn't happen at the moment either unless "Force" is selected during a manual sync).

Alternatives

Keep sync policy Replace=true.
@simu simu added the enhancement New feature or request label Oct 12, 2022
@corvus-ch
Copy link

Instead of fixing this for just one component, we will do so by changing the default of ArgoCD. The internal issue to track this progress is SYN-1873.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@simu @corvus-ch