Test: Update the validation to unblock query-engine-integration-tests #6117
Conversation
| // re-written files count is 2 and the added files count is 1 | ||
| assertThat(result).hasSize(1).containsExactly(row(2, 1)); | ||
| assertThat(result.get(0)[0]).isEqualTo(2); | ||
| assertThat(result.get(0)[1]).isEqualTo(1); |
There was a problem hiding this comment.
I did try .extracting() but it became too messy/complex as result.get(0) can have a bigger array in the latest iceberg.
There was a problem hiding this comment.
nit: .first() might help. Also, would just dropping hasSize(1) and using .contains(row(2, 1)) work?
Codecov ReportBase: 77.38% // Head: 77.38% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #6117 +/- ##
=========================================
Coverage 77.38% 77.38%
Complexity 3765 3765
=========================================
Files 565 565
Lines 17260 17260
Branches 1723 1723
=========================================
Hits 13357 13357
Misses 3278 3278
Partials 625 625
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| // re-written files count is 2 and the added files count is 1 | ||
| assertThat(result).hasSize(1).containsExactly(row(2, 1)); | ||
| assertThat(result.get(0)[0]).isEqualTo(2); | ||
| assertThat(result.get(0)[1]).isEqualTo(1); |
There was a problem hiding this comment.
nit: .first() might help. Also, would just dropping hasSize(1) and using .contains(row(2, 1)) work?
3 participants
Yesterday this PR got merged (apache/iceberg#6801) which introduces one more output value. Hence, the strict check fails.
This PR is to unblock
query-engine-integration-testsPart of fixing #6114