API,Core,Spark: Add rewritten bytes to rewrite data files procedure results #6801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
force-pushed
the
add-rewritten-bytes-compaction-results
branch
from
315b1e4 to
8e7d6c8
Compare
Fokko
approved these changes
Feb 10, 2023
| private final FileGroupInfo info; | ||
|
|
||
| /** | ||
| * @deprecated Will be removed in 1.3.0; use {@link |
Contributor
There was a problem hiding this comment.
Should we create an issue for this, and add it to the 1.3.0 milestone?
Contributor
Author
There was a problem hiding this comment.
I'll usually clean things like this up right after a release, so I'll open an issue for that shortly
Contributor
There was a problem hiding this comment.
Awesome, just to make sure that's in the collective memory of the community :)
...ensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewriteDataFilesProcedure.java
Show resolved
Hide resolved
Member
RussellSpitzer
left a comment
RussellSpitzer
left a comment
There was a problem hiding this comment.
I'm on board for this adjustment. Only issue is the test suite become a little brittle with the change. I left a note on how I think we can keep it from requiring a lot of patching in the future.
nastra
force-pushed
the
add-rewritten-bytes-compaction-results
branch
from
8e7d6c8 to
43465c7
Compare
spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteDataFilesAction.java
Outdated
Show resolved
Hide resolved
spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/SparkTestHelperBase.java
Show resolved
Hide resolved
...ensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewriteDataFilesProcedure.java
Show resolved
Hide resolved
nastra
force-pushed
the
add-rewritten-bytes-compaction-results
branch
from
43465c7 to
f7aa973
Compare
nastra
commented
Feb 14, 2023
| insertData(tableName(QUOTED_SPECIAL_CHARS_TABLE_NAME), 10); | ||
| insertData(tblName, 10); | ||
| // TODO: metadata table access currently fails with special chars in the table name | ||
| // long dataSizeBefore = testDataSize(tblName); |
Contributor
Author
There was a problem hiding this comment.
this seems like a bug to me where the table with special characters can't be found when running SELECT sum(file_size_in_bytes) from %s.files. It fails with
Caused by: java.io.FileNotFoundException: File file:/tmp/warehouse2890706410427132468.tmp/default/table:with.special:chars/metadata/2ae7cad2-3cff-4c92-9536-9bf9652f119d-m1.avro does not exist
at org.apache.hadoop.fs.RawLocalFileSystem.deprecatedGetFileStatus(RawLocalFileSystem.java:779)
at org.apache.hadoop.fs.RawLocalFileSystem.getFileLinkStatusInternal(RawLocalFileSystem.java:1100)
at org.apache.hadoop.fs.RawLocalFileSystem.getFileStatus(RawLocalFileSystem.java:769)
at org.apache.hadoop.fs.FilterFileSystem.getFileStatus(FilterFileSystem.java:462)
at org.apache.hadoop.fs.ChecksumFileSystem$ChecksumFSInputChecker.<init>(ChecksumFileSystem.java:160)
at org.apache.hadoop.fs.ChecksumFileSystem.open(ChecksumFileSystem.java:372)
at org.apache.hadoop.fs.FileSystem.open(FileSystem.java:976)
at org.apache.iceberg.hadoop.HadoopInputFile.newStream(HadoopInputFile.java:183)
Contributor
Author
There was a problem hiding this comment.
turns out this happened because of caching in the Hadoop catalog. Adding cache-enabled=false fixes this issue
nastra
force-pushed
the
add-rewritten-bytes-compaction-results
branch
from
e78ef43 to
a017a34
Compare
...ensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewriteDataFilesProcedure.java
Outdated
Show resolved
Hide resolved
nastra
force-pushed
the
add-rewritten-bytes-compaction-results
branch
from
a017a34 to
a00a9bd
Compare
nastra
commented
Feb 15, 2023
spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteDataFilesAction.java
Show resolved
Hide resolved
RussellSpitzer
approved these changes
Feb 15, 2023
Member
This was referenced Feb 16, 2023
snazy
pushed a commit
to projectnessie/nessie
that referenced
this pull request
Feb 16, 2023
…#6117) Yesterday this PR got merged (apache/iceberg#6801) which introduces one more output value. Hence, the strict check fails. This PR is to unblock `query-engine-integration-tests` Part of fixing #6114
krvikash
pushed a commit
to krvikash/iceberg
that referenced
this pull request
Mar 16, 2023
…esults (apache#6801) Co-authored-by: Alex Reid <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.