Skip to content

Workaround spotless plugin bug #4656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2022
Merged

Workaround spotless plugin bug #4656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,16 @@ jobs:
with:
gpg-private-key: ${{ secrets.MAVEN_GPG_PRIVATE_KEY }}

- name: Gradle / spotless
uses: gradle/gradle-build-action@v2
with:
# 'spotlessCheck' separate: workaround until https://github.com/diffplug/spotless/issues/1215 is fixed
arguments: spotlessCheck
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add comment that this is a workaround until <ticketlink> is fixed


- name: Gradle / compile
uses: gradle/gradle-build-action@v2
with:
arguments: spotlessCheck checkstyleMain checkstyleTest jar testClasses testJar
arguments: checkstyleMain checkstyleTest jar testClasses testJar

- name: Gradle / unit test
uses: gradle/gradle-build-action@v2
Expand All @@ -46,7 +52,8 @@ jobs:
- name: Gradle / check incl. integ-test
uses: gradle/gradle-build-action@v2
with:
arguments: check
# '-x spotlessCheck': workaround until https://github.com/diffplug/spotless/issues/1215 is fixed
arguments: check -x spotlessCheck

- name: Gradle / Gatling simulations
uses: gradle/gradle-build-action@v2
Expand Down
11 changes: 9 additions & 2 deletions .github/workflows/pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,16 @@ jobs:
- name: Setup Java, Maven
uses: ./.github/actions/dev-tool-java

- name: Gradle / spotless
uses: gradle/gradle-build-action@v2
with:
# 'spotlessCheck' separate: workaround until https://github.com/diffplug/spotless/issues/1215 is fixed
arguments: spotlessCheck

- name: Gradle / compile
uses: gradle/gradle-build-action@v2
with:
arguments: spotlessCheck checkstyleMain checkstyleTest jar testClasses testJar
arguments: checkstyleMain checkstyleTest jar testClasses testJar

- name: Gradle / unit test
uses: gradle/gradle-build-action@v2
Expand All @@ -66,7 +72,8 @@ jobs:
- name: Gradle / check incl. integ-test
uses: gradle/gradle-build-action@v2
with:
arguments: check
# '-x spotlessCheck': workaround until https://github.com/diffplug/spotless/issues/1215 is fixed
arguments: check -x spotlessCheck

- name: Gradle / Gatling simulations
uses: gradle/gradle-build-action@v2
Expand Down