Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround spotless plugin bug #4656

Merged
merged 1 commit into from
Jul 7, 2022
Merged

Conversation

snazy
Copy link
Member

@snazy snazy commented Jul 7, 2022

See #4655, required until diffplug/spotless#1215 is fixed. Similar to projectnessie/cel-java#185.

@snazy snazy requested a review from XN137 July 7, 2022 08:38
@codecov
Copy link

codecov bot commented Jul 7, 2022

Codecov Report

Merging #4656 (98278a2) into main (98278a2) will not change coverage.
The diff coverage is n/a.

❗ Current head 98278a2 differs from pull request most recent head a35abdf. Consider uploading reports for the commit a35abdf to get more accurate results

@@            Coverage Diff            @@
##               main    #4656   +/-   ##
=========================================
  Coverage     86.30%   86.30%           
  Complexity     3557     3557           
=========================================
  Files           413      413           
  Lines         16682    16682           
  Branches       1435     1435           
=========================================
  Hits          14397    14397           
  Misses         1790     1790           
  Partials        495      495           
Flag Coverage Δ
java 86.72% <0.00%> (ø)
javascript 81.98% <0.00%> (ø)
python 82.86% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98278a2...a35abdf. Read the comment docs.

XN137
XN137 previously approved these changes Jul 7, 2022
- name: Gradle / spotless
uses: gradle/gradle-build-action@v2
with:
arguments: spotlessCheck
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add comment that this is a workaround until <ticketlink> is fixed

@snazy snazy merged commit 5fccdb9 into projectnessie:main Jul 7, 2022
@snazy snazy deleted the workaround-spotless branch July 7, 2022 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants