Skip to content

Bump Iceberg from 0.12.0 to 0.12.1 #2543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nastra merged 1 commit into from
Nov 9, 2021
Merged

Bump Iceberg from 0.12.0 to 0.12.1 #2543

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@
<gatling.version>3.6.1</gatling.version>
<guava.version>31.0.1-jre</guava.version>
<hadoop.version>3.3.1</hadoop.version>
<iceberg.version>0.12.0</iceberg.version>
<iceberg.version>0.12.1</iceberg.version>
Copy link
Contributor

@ajantha-bhat ajantha-bhat Nov 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need to upgrade iceberg version when it cannot work with current Nessie ?
Doesn't it make sense to upgrade once iceberg side PR is merged ?

Copy link
Contributor Author

@nastra nastra Nov 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have a circular dependency in the project with Nessie+Iceberg. The SQL extensions depend on iceberg.version, which uses a Nessie version older than the current one, so this is independent from the PR you mentioned

Copy link
Contributor

@ajantha-bhat ajantha-bhat Nov 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. got it.

Now for this iceberg.version to work we are keeping nessie-client @ 0.9.2 in our pom even though we are in 0.12.1 version.

@rymurr , @snazy , @nastra : Should we move this ITNessieStatements to Nessie module in iceberg code ? so that Nessie code will be clean and always points to latest version for client as-well ?

Copy link
Contributor Author

@nastra nastra Nov 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajantha-bhat client.nessie.version points to 0.9.2 because that's the version that is being used by iceberg 0.12.1 currently. Also we can't move ITNessieStatements to Iceberg because the SQL extensions are part of the Nessie codebase, so the test should also be in the Nessie codebase

<immutables.version>2.8.9-ea-1</immutables.version>
<jackson.version>2.13.0</jackson.version>
<javax.version>4.0.1</javax.version>
Expand Down