Bump Iceberg from 0.12.0 to 0.12.1 #2543
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2543 +/- ##
============================================
+ Coverage 84.62% 84.64% +0.02%
- Complexity 1942 1943 +1
============================================
Files 270 270
Lines 11145 11145
Branches 802 802
============================================
+ Hits 9431 9434 +3
+ Misses 1399 1396 -3
Partials 315 315
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
snazy
left a comment
snazy
left a comment
There was a problem hiding this comment.
Let's not merge SNAPSHOT dependencies.
Yep that was definitely not my intention. I rather wanted to test that the newly published Iceberg snapshots can be consumed and that the current code in Nessie works with the latest Iceberg version that's coming from Once 0.12.1 is out, the snapshot repo will be removed again in this change here. |
Mind marking this PR as a draft then? |
| <guava.version>31.0.1-jre</guava.version> | ||
| <hadoop.version>3.3.1</hadoop.version> | ||
| <iceberg.version>0.12.0</iceberg.version> | ||
| <iceberg.version>0.12.1</iceberg.version> |
There was a problem hiding this comment.
why do we need to upgrade iceberg version when it cannot work with current Nessie ?
Doesn't it make sense to upgrade once iceberg side PR is merged ?
There was a problem hiding this comment.
we have a circular dependency in the project with Nessie+Iceberg. The SQL extensions depend on iceberg.version, which uses a Nessie version older than the current one, so this is independent from the PR you mentioned
There was a problem hiding this comment.
ok. got it.
Now for this iceberg.version to work we are keeping nessie-client @ 0.9.2 in our pom even though we are in 0.12.1 version.
@rymurr , @snazy , @nastra : Should we move this ITNessieStatements to Nessie module in iceberg code ? so that Nessie code will be clean and always points to latest version for client as-well ?
There was a problem hiding this comment.
@ajantha-bhat client.nessie.version points to 0.9.2 because that's the version that is being used by iceberg 0.12.1 currently. Also we can't move ITNessieStatements to Iceberg because the SQL extensions are part of the Nessie codebase, so the test should also be in the Nessie codebase
3 participants
Uses currently 0.13.0-SNAPSHOT until 0.12.1 is actually released