Only accept NamedRefs in REST API#1583
Merged
nastra merged 3 commits intoprojectnessie:mainfrom Jul 13, 2021
Merged
Conversation
nastra
force-pushed
the
rest-api-named-refs-only
branch
from
0334ddb to
dd61ca2
Compare
Codecov Report
@@ Coverage Diff @@
## main #1583 +/- ##
============================================
+ Coverage 76.13% 76.15% +0.01%
- Complexity 2104 2105 +1
============================================
Files 283 283
Lines 12752 12768 +16
Branches 1020 1024 +4
============================================
+ Hits 9709 9723 +14
Misses 2565 2565
- Partials 478 480 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
nastra
force-pushed
the
rest-api-named-refs-only
branch
from
7574660 to
1d9a3da
Compare
snazy
reviewed
Jul 12, 2021
Member
snazy
left a comment
snazy
left a comment
There was a problem hiding this comment.
Not sure whether I'm too early with my review, but am I missing changes to TreeApi here?
If this is not yet ready, ignore me
servers/services/src/main/java/org/projectnessie/services/rest/BaseResource.java
Outdated
Show resolved
Hide resolved
servers/services/src/main/java/org/projectnessie/services/rest/TreeResource.java
Show resolved
Hide resolved
servers/jax-rs/src/test/java/org/projectnessie/jaxrs/AbstractTestRest.java
Outdated
Show resolved
Hide resolved
Contributor
Author
you were indeed quite early to the review because I didn't have time to review my own code yet ;) I don't think we need any changes to the |
rymurr
reviewed
Jul 13, 2021
Contributor
rymurr
left a comment
rymurr
left a comment
There was a problem hiding this comment.
How do we support time travel? eg how do I read from a past hash?
rymurr
approved these changes
Jul 13, 2021
Contributor
Author
Just for completeness, we talked about this on Slack and decided that we probably need to have an additional I'm working on a follow-up PR that addresses this. |
snazy
added a commit
to snazy/iceberg
that referenced
this pull request
Jul 15, 2021
Apply changes to Iceberg required by API changes in Nessie: * [Re-introduce wrapper classes for query params of CommitLog/Entries](projectnessie/nessie#1595) * [Server-side commit range filtering](projectnessie/nessie#1596) * [Add hashOnRef query param to support time travel on a named ref](projectnessie/nessie#1589) * [Only accept NamedRefs in REST API](projectnessie/nessie#1583)
snazy
added a commit
to snazy/iceberg
that referenced
this pull request
Jul 15, 2021
Apply changes to Iceberg required by API changes in Nessie: * [Re-introduce wrapper classes for query params of CommitLog/Entries](projectnessie/nessie#1595) * [Server-side commit range filtering](projectnessie/nessie#1596) * [Add hashOnRef query param to support time travel on a named ref](projectnessie/nessie#1589) * [Only accept NamedRefs in REST API](projectnessie/nessie#1583)
rymurr
pushed a commit
to apache/iceberg
that referenced
this pull request
Jul 15, 2021
* Bump Nessie to 0.8.2 + replace Gradle plugin with new JUnit extension More changes in this PR in following commits. Replace Gradle plugin with new JUnit extension. See [Add JAX-RS tests and add JUnit/Jupyter extension](projectnessie/nessie#1566) * Changes required by Nessie-API changes Apply changes to Iceberg required by API changes in Nessie: * [Re-introduce wrapper classes for query params of CommitLog/Entries](projectnessie/nessie#1595) * [Server-side commit range filtering](projectnessie/nessie#1596) * [Add hashOnRef query param to support time travel on a named ref](projectnessie/nessie#1589) * [Only accept NamedRefs in REST API](projectnessie/nessie#1583) * Bugfix: must send the Contents.id of the existing table Nessie's `Contents.id` is a random ID generated when the `Contents.Key` is first used (think: CREATE TABLE) and must not be changed. This change addresses a bug in the Iceberg-Nesie code that caused a new id for every change. * Throw `CommitStateUnknownException` for `renameTable` as well Follow-up of #2515 * Fix race-condition & save one roundtrip to Nessie during "commit" When commiting a change, the Nessie-API now returns the hash of the commit for the change. This returned hash should then be used as the "expected hash" for the next commit. The previous approach was to commit the change to Nessie and then do another request to retrieve the new hash of HEAD. This old approach is prone to a race condition, namely when another commit happens after "this" commit but before retrieving the "new HEAD", so "this" instance would wrongly ignore the other commit's changes during conflict checks. See [Let VersionStore.create()+commit() return the current hash](projectnessie/nessie#1089)
minchowang
pushed a commit
to minchowang/iceberg
that referenced
this pull request
Aug 2, 2021
* Bump Nessie to 0.8.2 + replace Gradle plugin with new JUnit extension More changes in this PR in following commits. Replace Gradle plugin with new JUnit extension. See [Add JAX-RS tests and add JUnit/Jupyter extension](projectnessie/nessie#1566) * Changes required by Nessie-API changes Apply changes to Iceberg required by API changes in Nessie: * [Re-introduce wrapper classes for query params of CommitLog/Entries](projectnessie/nessie#1595) * [Server-side commit range filtering](projectnessie/nessie#1596) * [Add hashOnRef query param to support time travel on a named ref](projectnessie/nessie#1589) * [Only accept NamedRefs in REST API](projectnessie/nessie#1583) * Bugfix: must send the Contents.id of the existing table Nessie's `Contents.id` is a random ID generated when the `Contents.Key` is first used (think: CREATE TABLE) and must not be changed. This change addresses a bug in the Iceberg-Nesie code that caused a new id for every change. * Throw `CommitStateUnknownException` for `renameTable` as well Follow-up of apache#2515 * Fix race-condition & save one roundtrip to Nessie during "commit" When commiting a change, the Nessie-API now returns the hash of the commit for the change. This returned hash should then be used as the "expected hash" for the next commit. The previous approach was to commit the change to Nessie and then do another request to retrieve the new hash of HEAD. This old approach is prone to a race condition, namely when another commit happens after "this" commit but before retrieving the "new HEAD", so "this" instance would wrongly ignore the other commit's changes during conflict checks. See [Let VersionStore.create()+commit() return the current hash](projectnessie/nessie#1089)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is