Conversation
Closed
Codecov Report
@@ Coverage Diff @@
## main #1566 +/- ##
=============================================
+ Coverage 56.13% 76.24% +20.11%
- Complexity 0 2084 +2084
=============================================
Files 150 281 +131
Lines 4949 12644 +7695
Branches 420 1006 +586
=============================================
+ Hits 2778 9641 +6863
- Misses 2029 2528 +499
- Partials 142 475 +333
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
nastra
force-pushed
the
jaxrs
branch
3 times, most recently
from
3b9b544 to
f73cbcf
Compare
rymurr
reviewed
Jul 9, 2021
Contributor
rymurr
left a comment
rymurr
left a comment
There was a problem hiding this comment.
A few minor comments. Overall i think it looks good.
servers/services/src/main/java/org/projectnessie/services/rest/ContentsResource.java
Show resolved
Hide resolved
...ces/src/main/java/org/projectnessie/services/rest/NessieJaxRsJsonMappingExceptionMapper.java
Show resolved
Hide resolved
snazy
reviewed
Jul 9, 2021
servers/services/src/test/java/org/projectnessie/services/rest/AbstractTestRest.java
Show resolved
Hide resolved
servers/services/src/test/java/org/projectnessie/services/rest/TestJerseyRest.java
Outdated
Show resolved
Hide resolved
nastra
force-pushed
the
jaxrs
branch
2 times, most recently
from
4fb41df to
3ab28aa
Compare
snazy
reviewed
Jul 9, 2021
nastra
force-pushed
the
jaxrs
branch
2 times, most recently
from
d6b5682 to
9b34beb
Compare
Co-authored-by: Laurent Goujon <laurent@dremio.com> Add JAX-RS tests for Nessie server implementation. Tests use Jersey and Weld as a alternative container environment.
snazy
approved these changes
Jul 12, 2021
Member
snazy
left a comment
snazy
left a comment
There was a problem hiding this comment.
+1
Just make sure to run ./mvnw clean install -pl servers/quarkus-server -Pnative locally.
snazy
added a commit
to snazy/iceberg
that referenced
this pull request
Jul 15, 2021
More changes in this PR in following commits. Replace Gradle plugin with new JUnit extension. See [Add JAX-RS tests and add JUnit/Jupyter extension](projectnessie/nessie#1566)
snazy
added a commit
to snazy/iceberg
that referenced
this pull request
Jul 15, 2021
More changes in this PR in following commits. Replace Gradle plugin with new JUnit extension. See [Add JAX-RS tests and add JUnit/Jupyter extension](projectnessie/nessie#1566)
rymurr
pushed a commit
to apache/iceberg
that referenced
this pull request
Jul 15, 2021
* Bump Nessie to 0.8.2 + replace Gradle plugin with new JUnit extension More changes in this PR in following commits. Replace Gradle plugin with new JUnit extension. See [Add JAX-RS tests and add JUnit/Jupyter extension](projectnessie/nessie#1566) * Changes required by Nessie-API changes Apply changes to Iceberg required by API changes in Nessie: * [Re-introduce wrapper classes for query params of CommitLog/Entries](projectnessie/nessie#1595) * [Server-side commit range filtering](projectnessie/nessie#1596) * [Add hashOnRef query param to support time travel on a named ref](projectnessie/nessie#1589) * [Only accept NamedRefs in REST API](projectnessie/nessie#1583) * Bugfix: must send the Contents.id of the existing table Nessie's `Contents.id` is a random ID generated when the `Contents.Key` is first used (think: CREATE TABLE) and must not be changed. This change addresses a bug in the Iceberg-Nesie code that caused a new id for every change. * Throw `CommitStateUnknownException` for `renameTable` as well Follow-up of #2515 * Fix race-condition & save one roundtrip to Nessie during "commit" When commiting a change, the Nessie-API now returns the hash of the commit for the change. This returned hash should then be used as the "expected hash" for the next commit. The previous approach was to commit the change to Nessie and then do another request to retrieve the new hash of HEAD. This old approach is prone to a race condition, namely when another commit happens after "this" commit but before retrieving the "new HEAD", so "this" instance would wrongly ignore the other commit's changes during conflict checks. See [Let VersionStore.create()+commit() return the current hash](projectnessie/nessie#1089)
minchowang
pushed a commit
to minchowang/iceberg
that referenced
this pull request
Aug 2, 2021
* Bump Nessie to 0.8.2 + replace Gradle plugin with new JUnit extension More changes in this PR in following commits. Replace Gradle plugin with new JUnit extension. See [Add JAX-RS tests and add JUnit/Jupyter extension](projectnessie/nessie#1566) * Changes required by Nessie-API changes Apply changes to Iceberg required by API changes in Nessie: * [Re-introduce wrapper classes for query params of CommitLog/Entries](projectnessie/nessie#1595) * [Server-side commit range filtering](projectnessie/nessie#1596) * [Add hashOnRef query param to support time travel on a named ref](projectnessie/nessie#1589) * [Only accept NamedRefs in REST API](projectnessie/nessie#1583) * Bugfix: must send the Contents.id of the existing table Nessie's `Contents.id` is a random ID generated when the `Contents.Key` is first used (think: CREATE TABLE) and must not be changed. This change addresses a bug in the Iceberg-Nesie code that caused a new id for every change. * Throw `CommitStateUnknownException` for `renameTable` as well Follow-up of apache#2515 * Fix race-condition & save one roundtrip to Nessie during "commit" When commiting a change, the Nessie-API now returns the hash of the commit for the change. This returned hash should then be used as the "expected hash" for the next commit. The previous approach was to commit the change to Nessie and then do another request to retrieve the new hash of HEAD. This old approach is prone to a race condition, namely when another commit happens after "this" commit but before retrieving the "new HEAD", so "this" instance would wrongly ignore the other commit's changes during conflict checks. See [Let VersionStore.create()+commit() return the current hash](projectnessie/nessie#1089)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add JAX-RS tests for Nessie server implementation. Tests use Jersey and
Weld as a alternative container environment.
This change is