Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove description field from CRDs #2032

Merged

Conversation

caseydavenport
Copy link
Member

@caseydavenport caseydavenport commented Jun 7, 2018

Description

This isn't a real field - client-side validation will throw errors on this now, so let's remove it.

Todos

  • Tests
  • Documentation
  • Release note

Release Note

None required

@caseydavenport caseydavenport requested a review from tmjd June 7, 2018 22:41
Copy link
Member

@tmjd tmjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caseydavenport caseydavenport merged commit 6aecd08 into projectcalico:master Jun 7, 2018
@caseydavenport caseydavenport deleted the remove-description-crds branch June 7, 2018 23:54
dghubble added a commit to poseidon/terraform-render-bootstrap that referenced this pull request Aug 15, 2018
* Most upstream changes were buried in calico#1884 which
switched from non-templated manifests to templating
* projectcalico/calico#1884
* projectcalico/calico#1853
* projectcalico/calico#2069
* projectcalico/calico#2032
* projectcalico/calico#1841
* projectcalico/calico#1770
dghubble added a commit to poseidon/terraform-render-bootstrap that referenced this pull request Aug 15, 2018
* Most upstream changes were buried in calico#1884 which
switched from non-templated manifests to templating
* projectcalico/calico#1884
* projectcalico/calico#1853
* projectcalico/calico#2069
* projectcalico/calico#2032
* projectcalico/calico#1841
* projectcalico/calico#1770
dghubble added a commit to poseidon/typhoon that referenced this pull request Aug 15, 2018
* Most upstream changes were buried in calico#1884 which
switched from non-templated manifests to templating
* projectcalico/calico#1884
* projectcalico/calico#1853
* projectcalico/calico#2069
* projectcalico/calico#2032
* projectcalico/calico#1841
* projectcalico/calico#1770
dghubble added a commit to poseidon/terraform-render-bootstrap that referenced this pull request Aug 15, 2018
* Most upstream changes were buried in calico#1884 which
switched from non-templated manifests to templating
* projectcalico/calico#1884
* projectcalico/calico#1853
* projectcalico/calico#2069
* projectcalico/calico#2032
* projectcalico/calico#1841
* projectcalico/calico#1770
dghubble added a commit to poseidon/typhoon that referenced this pull request Aug 15, 2018
* Most upstream changes were buried in calico#1884 which
switched from non-templated manifests to templating
* projectcalico/calico#1884
* projectcalico/calico#1853
* projectcalico/calico#2069
* projectcalico/calico#2032
* projectcalico/calico#1841
* projectcalico/calico#1770
dghubble added a commit to poseidon/terraform-render-bootstrap that referenced this pull request Aug 25, 2018
* Most upstream changes were buried in calico#1884 which
switched from non-templated manifests to templating
* projectcalico/calico#1884
* projectcalico/calico#1853
* projectcalico/calico#2069
* projectcalico/calico#2032
* projectcalico/calico#1841
* projectcalico/calico#1770
dghubble added a commit to poseidon/typhoon that referenced this pull request Aug 25, 2018
* Most upstream changes were buried in calico#1884 which
switched from non-templated manifests to templating
* projectcalico/calico#1884
* projectcalico/calico#1853
* projectcalico/calico#2069
* projectcalico/calico#2032
* projectcalico/calico#1841
* projectcalico/calico#1770
dghubble added a commit to poseidon/typhoon that referenced this pull request Aug 25, 2018
* Most upstream changes were buried in calico#1884 which
switched from non-templated manifests to templating
* projectcalico/calico#1884
* projectcalico/calico#1853
* projectcalico/calico#2069
* projectcalico/calico#2032
* projectcalico/calico#1841
* projectcalico/calico#1770
dghubble added a commit to poseidon/terraform-render-bootstrap that referenced this pull request Aug 26, 2018
* Most upstream changes were buried in calico#1884 which
switched from non-templated manifests to templating
* projectcalico/calico#1884
* projectcalico/calico#1853
* projectcalico/calico#2069
* projectcalico/calico#2032
* projectcalico/calico#1841
* projectcalico/calico#1770
tegamckinney pushed a commit to flexdrive/terraform-render-bootkube that referenced this pull request Dec 4, 2018
* Most upstream changes were buried in calico#1884 which
switched from non-templated manifests to templating
* projectcalico/calico#1884
* projectcalico/calico#1853
* projectcalico/calico#2069
* projectcalico/calico#2032
* projectcalico/calico#1841
* projectcalico/calico#1770
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants