-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove description field from CRDs #2032
Merged
caseydavenport
merged 1 commit into
projectcalico:master
from
caseydavenport:remove-description-crds
Jun 7, 2018
Merged
Remove description field from CRDs #2032
caseydavenport
merged 1 commit into
projectcalico:master
from
caseydavenport:remove-description-crds
Jun 7, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmjd
approved these changes
Jun 7, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dghubble
added a commit
to poseidon/terraform-render-bootstrap
that referenced
this pull request
Aug 15, 2018
* Most upstream changes were buried in calico#1884 which switched from non-templated manifests to templating * projectcalico/calico#1884 * projectcalico/calico#1853 * projectcalico/calico#2069 * projectcalico/calico#2032 * projectcalico/calico#1841 * projectcalico/calico#1770
dghubble
added a commit
to poseidon/terraform-render-bootstrap
that referenced
this pull request
Aug 15, 2018
* Most upstream changes were buried in calico#1884 which switched from non-templated manifests to templating * projectcalico/calico#1884 * projectcalico/calico#1853 * projectcalico/calico#2069 * projectcalico/calico#2032 * projectcalico/calico#1841 * projectcalico/calico#1770
dghubble
added a commit
to poseidon/typhoon
that referenced
this pull request
Aug 15, 2018
* Most upstream changes were buried in calico#1884 which switched from non-templated manifests to templating * projectcalico/calico#1884 * projectcalico/calico#1853 * projectcalico/calico#2069 * projectcalico/calico#2032 * projectcalico/calico#1841 * projectcalico/calico#1770
This was referenced Aug 15, 2018
dghubble
added a commit
to poseidon/terraform-render-bootstrap
that referenced
this pull request
Aug 15, 2018
* Most upstream changes were buried in calico#1884 which switched from non-templated manifests to templating * projectcalico/calico#1884 * projectcalico/calico#1853 * projectcalico/calico#2069 * projectcalico/calico#2032 * projectcalico/calico#1841 * projectcalico/calico#1770
dghubble
added a commit
to poseidon/typhoon
that referenced
this pull request
Aug 15, 2018
* Most upstream changes were buried in calico#1884 which switched from non-templated manifests to templating * projectcalico/calico#1884 * projectcalico/calico#1853 * projectcalico/calico#2069 * projectcalico/calico#2032 * projectcalico/calico#1841 * projectcalico/calico#1770
dghubble
added a commit
to poseidon/terraform-render-bootstrap
that referenced
this pull request
Aug 25, 2018
* Most upstream changes were buried in calico#1884 which switched from non-templated manifests to templating * projectcalico/calico#1884 * projectcalico/calico#1853 * projectcalico/calico#2069 * projectcalico/calico#2032 * projectcalico/calico#1841 * projectcalico/calico#1770
dghubble
added a commit
to poseidon/typhoon
that referenced
this pull request
Aug 25, 2018
* Most upstream changes were buried in calico#1884 which switched from non-templated manifests to templating * projectcalico/calico#1884 * projectcalico/calico#1853 * projectcalico/calico#2069 * projectcalico/calico#2032 * projectcalico/calico#1841 * projectcalico/calico#1770
dghubble
added a commit
to poseidon/typhoon
that referenced
this pull request
Aug 25, 2018
* Most upstream changes were buried in calico#1884 which switched from non-templated manifests to templating * projectcalico/calico#1884 * projectcalico/calico#1853 * projectcalico/calico#2069 * projectcalico/calico#2032 * projectcalico/calico#1841 * projectcalico/calico#1770
dghubble
added a commit
to poseidon/terraform-render-bootstrap
that referenced
this pull request
Aug 26, 2018
* Most upstream changes were buried in calico#1884 which switched from non-templated manifests to templating * projectcalico/calico#1884 * projectcalico/calico#1853 * projectcalico/calico#2069 * projectcalico/calico#2032 * projectcalico/calico#1841 * projectcalico/calico#1770
tegamckinney
pushed a commit
to flexdrive/terraform-render-bootkube
that referenced
this pull request
Dec 4, 2018
* Most upstream changes were buried in calico#1884 which switched from non-templated manifests to templating * projectcalico/calico#1884 * projectcalico/calico#1853 * projectcalico/calico#2069 * projectcalico/calico#2032 * projectcalico/calico#1841 * projectcalico/calico#1770
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This isn't a real field - client-side validation will throw errors on this now, so let's remove it.
Todos
Release Note