Add rbac for serviceaccounts. #1853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -78,6 +78,13 @@ rules: | |||
| - list | |||
| - update | |||
| - watch | |||
| - apiGroups: [""] | |||
There was a problem hiding this comment.
I think you can just add - serviceaccounts to the block at the top which includes namespaces.
|
@saumoh I think we also need a change to the etcd RBAC file for kube-controllers. |
caseydavenport
approved these changes
Apr 6, 2018
dghubble
added a commit
to poseidon/terraform-render-bootstrap
that referenced
this pull request
Aug 15, 2018
* Most upstream changes were buried in calico#1884 which switched from non-templated manifests to templating * projectcalico/calico#1884 * projectcalico/calico#1853 * projectcalico/calico#2069 * projectcalico/calico#2032 * projectcalico/calico#1841 * projectcalico/calico#1770
dghubble
added a commit
to poseidon/terraform-render-bootstrap
that referenced
this pull request
Aug 15, 2018
* Most upstream changes were buried in calico#1884 which switched from non-templated manifests to templating * projectcalico/calico#1884 * projectcalico/calico#1853 * projectcalico/calico#2069 * projectcalico/calico#2032 * projectcalico/calico#1841 * projectcalico/calico#1770
dghubble
added a commit
to poseidon/typhoon
that referenced
this pull request
Aug 15, 2018
* Most upstream changes were buried in calico#1884 which switched from non-templated manifests to templating * projectcalico/calico#1884 * projectcalico/calico#1853 * projectcalico/calico#2069 * projectcalico/calico#2032 * projectcalico/calico#1841 * projectcalico/calico#1770
This was referenced Aug 15, 2018
dghubble
added a commit
to poseidon/terraform-render-bootstrap
that referenced
this pull request
Aug 15, 2018
* Most upstream changes were buried in calico#1884 which switched from non-templated manifests to templating * projectcalico/calico#1884 * projectcalico/calico#1853 * projectcalico/calico#2069 * projectcalico/calico#2032 * projectcalico/calico#1841 * projectcalico/calico#1770
dghubble
added a commit
to poseidon/typhoon
that referenced
this pull request
Aug 15, 2018
* Most upstream changes were buried in calico#1884 which switched from non-templated manifests to templating * projectcalico/calico#1884 * projectcalico/calico#1853 * projectcalico/calico#2069 * projectcalico/calico#2032 * projectcalico/calico#1841 * projectcalico/calico#1770
dghubble
added a commit
to poseidon/terraform-render-bootstrap
that referenced
this pull request
Aug 25, 2018
* Most upstream changes were buried in calico#1884 which switched from non-templated manifests to templating * projectcalico/calico#1884 * projectcalico/calico#1853 * projectcalico/calico#2069 * projectcalico/calico#2032 * projectcalico/calico#1841 * projectcalico/calico#1770
dghubble
added a commit
to poseidon/typhoon
that referenced
this pull request
Aug 25, 2018
* Most upstream changes were buried in calico#1884 which switched from non-templated manifests to templating * projectcalico/calico#1884 * projectcalico/calico#1853 * projectcalico/calico#2069 * projectcalico/calico#2032 * projectcalico/calico#1841 * projectcalico/calico#1770
dghubble
added a commit
to poseidon/typhoon
that referenced
this pull request
Aug 25, 2018
* Most upstream changes were buried in calico#1884 which switched from non-templated manifests to templating * projectcalico/calico#1884 * projectcalico/calico#1853 * projectcalico/calico#2069 * projectcalico/calico#2032 * projectcalico/calico#1841 * projectcalico/calico#1770
dghubble
added a commit
to poseidon/terraform-render-bootstrap
that referenced
this pull request
Aug 26, 2018
* Most upstream changes were buried in calico#1884 which switched from non-templated manifests to templating * projectcalico/calico#1884 * projectcalico/calico#1853 * projectcalico/calico#2069 * projectcalico/calico#2032 * projectcalico/calico#1841 * projectcalico/calico#1770
tegamckinney
pushed a commit
to flexdrive/terraform-render-bootkube
that referenced
this pull request
Dec 4, 2018
* Most upstream changes were buried in calico#1884 which switched from non-templated manifests to templating * projectcalico/calico#1884 * projectcalico/calico#1853 * projectcalico/calico#2069 * projectcalico/calico#2032 * projectcalico/calico#1841 * projectcalico/calico#1770
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We should be allowed to watch service accounts now that we support it in rules.
I think this is the only update need in master and not for any revisions.
Not sure if there are other rbac's that should also be updated?
cc: @caseydavenport