-
Notifications
You must be signed in to change notification settings - Fork 58
[1.12.3] Signature verification: fix pull-by-digest #213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.12.3] Signature verification: fix pull-by-digest #213
Conversation
365e457 to
8a40a88
Compare
|
LGTM, but Lets get @mtrmac review. |
mtrmac
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is more or less a vendoring of containers/image, right? If so then that should be fine.
There does seem to be some discrepancy between the comments above the tests and the actual tests AFIACT, though. I don’t have a terribly strong opinion on whether that should be resolved by adding tests or removing comments :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can’t see a test for pulling by tag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the one above this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, s/that I can pull by a digest and tag/thaat I can also pull by a digest/?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can’t see a test for pulling by tag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the first one in this chain
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAICT there is only https://github.com/projectatomic/docker/pull/213/files#diff-8c285cfed55b08d027aed4e479cb9435R736 testing digest use.
Signed-off-by: Antonio Murdaca <[email protected]>
8a40a88 to
3502b63
Compare
|
@mtrmac fixed
correct |
|
@rhatdan good to go now! |
No description provided.