Add support for digest references to signature enforcement #156
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
signedIdentitytype:matchRepoDigestOrExact, and makes it the default.With
matchRepoDigestOrExact, Tag references require a signature with a matching repo:tag (Exact), digest references require a signature with a matching repo (and any tag [or digest];RepoDigest), with the digest itself still being validated inimage.UnparsedImage, independently of signature processing.Rationale from mtrmac@6e18d30#commitcomment-19557682 for not doing a digest check in the identity matching component:
Users can still opt into strict checking by specifying
matchExactinsignedIdentity.I am not entirely happy with the
matchRepoDigestOrExactname, but it’s difficult to be both precise and short, and, ultimately, when this is the default, most users won’t see it. Suggestions for improvement definitely welcome, though.This is an alternative to #129 , and fixes #99.